Skip to content

Commit 307aca8

Browse files
Merge pull request #79 from GRAPHISOFT/p4-sdk-build-fix
Fix build on macOS with newer P4 SDK versions by linking with the p4s…
2 parents ef29468 + b973b8d commit 307aca8

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/build.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ jobs:
2020
${{ runner.OS }}-p4-fusion-vendor-cache-
2121
2222
# Adopted from: https://github.com/sourcegraph/sourcegraph/blob/main/cmd/gitserver/p4-fusion-install-alpine.sh#L82
23-
- name: Install OpenSSL 1.0.2t
23+
- name: Install OpenSSL 1.1.1w
2424
run: |
2525
pushd vendor
2626
2727
mkdir -p openssl-src
28-
wget https://www.openssl.org/source/openssl-1.0.2t.tar.gz
29-
tar -C openssl-src -xzf openssl-1.0.2t.tar.gz --strip 1
28+
wget https://www.openssl.org/source/openssl-1.1.1w.tar.gz
29+
tar -C openssl-src -xzf openssl-1.1.1w.tar.gz --strip 1
3030
pushd openssl-src
3131
./config
3232
make build_libs
@@ -38,8 +38,8 @@ jobs:
3838
- name: Install Helix Core C++ API
3939
run: |
4040
mkdir -p vendor/helix-core-api/linux
41-
wget https://www.perforce.com/downloads/perforce/r21.1/bin.linux26x86_64/p4api.tgz
42-
tar -C vendor/helix-core-api/linux -xzf p4api.tgz --strip 1
41+
wget https://www.perforce.com/downloads/perforce/r24.1/bin.linux26x86_64/p4api-glibc2.12-openssl1.1.1.tgz
42+
tar -C vendor/helix-core-api/linux -xzf p4api-glibc2.12-openssl1.1.1.tgz --strip 1
4343
4444
- name: Configure CMake cache
4545
run: |

p4-fusion/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,9 @@ target_link_libraries(p4-fusion PUBLIC
4545
client
4646
rpc
4747
supp
48+
p4script_cstub
4849
${OPENSSL_SSL_LIBRARIES}
4950
${OPENSSL_CRYPTO_LIBRARIES}
50-
p4script
51-
p4script_c
5251
git2
5352
minitrace
5453
)

0 commit comments

Comments
 (0)