Skip to content

Prevent deploy of jar to Maven repo if only contains a MANIFEST.MF file #85

@plaird

Description

@plaird

In PR #84 we had a case where a user was trying to deploy a java_binary rule jar to the Maven repo. But the CI job was not running the build for the :* target, so the xyz_deploy.jar was missing so the logic picked the xyz.jar instead. For java_binary rules, that jar is empty except for a MANIFEST.MF file. Since such a jar is never(?) useful, we should fail on that case.

https://github.com/salesforce/pomgen/blob/master/maven/maven_functions.sh#L231

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions