remove tie to lwc-dev-mobile-core and sf-plugins-core (#185)

* remove tie to lwc-dev-mobile-core and sf-plugins-core

* address pr comments

Author: ben-zhang-at-salesforce

package-lock.json

@@ -108,17 +108,19 @@
         "@babel/core": "^7.26.0",
         "@babel/preset-env": "^7.27.2",
         "@istanbuljs/nyc-config-typescript": "^1.0.2",
+        "@jsforce/jsforce-node": "^3.9.1",
         "@types/babel__traverse": "7.20.7",
         "@types/babel-core": "6.25.10",
         "@types/cli-progress": "^3.11.6",
         "@types/inquirer": "^9.0.8",
         "@types/mocha": "^10.0.9",
-        "@types/node": "^22.8.6",
+        "@types/node": "22.16.3",
+        "@types/semver": "^7.7.0",
         "@types/sinon": "^17.0.3",
         "@types/vscode": "1.77.0",
         "@types/yaml": "^1.9.7",
-        "@typescript-eslint/eslint-plugin": "^8.35.0",
-        "@typescript-eslint/parser": "^8.12.2",
+        "@typescript-eslint/eslint-plugin": "^8.36.0",
+        "@typescript-eslint/parser": "^8.36.0",
         "@vscode/l10n-dev": "^0.0.35",
         "@vscode/test-electron": "^2.5.2",
         "@vscode/vsce": "^3.5.0",
@@ -140,9 +142,7 @@
         "@babel/traverse": "^7.27.4",
         "@graphql-tools/graphql-tag-pluck": "^8.3.19",
         "@graphql-tools/utils": "^10.5.4",
-        "@salesforce/core": "^5.3.12",
-        "@salesforce/lwc-dev-mobile-core": "^3.3.1",
-        "@salesforce/sf-plugins-core": "^12.2.2",
+        "@salesforce/core": "^8.18.1",
         "@vscode/l10n": "^0.0.18",
         "graphql-tag": "^2.12.6",
         "vscode-html-languageservice": "^5.5.0",

package.json

@@ -6,7 +6,7 @@
  */
 
 import { ProgressLocation, Uri, window, l10n } from 'vscode';
-import { CommonUtils } from '@salesforce/lwc-dev-mobile-core/lib/common/CommonUtils';
+import { CommonUtils } from '../../utils/commonUtils';
 import { InstructionsWebviewProvider } from '../../webviews/instructions';
 
 export class BriefcaseCommand {

src/commands/wizard/briefcaseCommand.ts

@@ -7,7 +7,7 @@
 
 import { Uri, WebviewPanel, commands, l10n, window } from 'vscode';
 import * as process from 'process';
-import { CommonUtils } from '@salesforce/lwc-dev-mobile-core/lib/common/CommonUtils';
+import { CommonUtils } from '../../utils/commonUtils';
 import { InstructionsWebviewProvider } from '../../webviews/instructions';
 import { wizardCommand } from './onboardingWizard';
 import { CoreExtensionService } from '../../services/CoreExtensionService';

src/commands/wizard/configureProjectCommand.ts

@@ -10,7 +10,7 @@ import { access } from 'fs/promises';
 import { InstructionsWebviewProvider } from '../../webviews/instructions';
 import { UEMParser } from '../../utils/uemParser';
 import { WorkspaceUtils } from '../../utils/workspaceUtils';
-import { CommonUtils } from '@salesforce/lwc-dev-mobile-core';
+import { CommonUtils } from '../../utils/commonUtils';
 import { OrgUtils } from '../../utils/orgUtils';
 import * as fs from 'fs';
 import { CodeBuilder } from '../../utils/codeBuilder';
@@ -115,7 +115,7 @@ export class LwcGenerationCommand {
             try {
                 await access(landingPagePath);
                 const uem = CommonUtils.loadJsonFromFile(landingPagePath);
-                getSObjectsStatus.sobjects = UEMParser.findSObjects(uem);
+                getSObjectsStatus.sobjects = UEMParser.findSObjects(uem as any);
                 resolve(getSObjectsStatus);
             } catch (err) {
                 console.warn(

src/commands/wizard/lwcGenerationCommand.ts

@@ -161,7 +161,9 @@ export function generateEntityTree(rootASTNode: ASTNode): RootNode {
                     let parentEntity = undefined;
                     try {
                         parentEntity = resolveEntityNodeForProperty(ancestors);
-                    } catch (e) {}
+                    } catch (e) {
+                        /* empty */
+                    }
                     if (parentEntity === undefined) {
                         return;
                     }

src/lsp/server/utils/gqlUtils.ts

@@ -0,0 +1,60 @@
+/*
+ * Copyright (c) 2021, salesforce.com, inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: MIT
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
+ */
+import * as childProcess from 'node:child_process';
+import { Logger } from '@salesforce/core';
+import { AnyJson } from '@salesforce/ts-types';
+import * as fs from 'fs';
+
+export class CommonUtils {
+    /**
+     * Given the path to a JSON file, it will load the content of the file.
+     *
+     * @param file The path to the JSON file.
+     * @returns Content of the file as JSON object.
+     */
+    public static loadJsonFromFile(file: string): AnyJson {
+        const fileContent = fs.readFileSync(file, 'utf8');
+        const json = JSON.parse(fileContent) as AnyJson;
+        return json;
+    }
+
+    /**
+     * Execute a command asynchronously using child_process.exec()
+     *
+     * @param command The command to be executed.
+     * @returns A promise containing the results of stdout and stderr
+     */
+    public static async executeCommandAsync(
+        command: string,
+        logger?: Logger
+    ): Promise<{ stdout: string; stderr: string }> {
+        return new Promise<{ stdout: string; stderr: string }>(
+            (resolve, reject) => {
+                logger?.debug(`Executing command: '${command}'`);
+                childProcess.exec(command, (error, stdout, stderr) => {
+                    if (error) {
+                        logger?.error(`Error executing command '${command}':`);
+
+                        // also include stderr & stdout for more detailed error
+                        let msg = error.message;
+                        if (stderr && stderr.length > 0) {
+                            msg = `${msg}\nstderr:\n${stderr}`;
+                        }
+                        if (stdout && stdout.length > 0) {
+                            msg = `${msg}\nstdout:\n${stdout}`;
+                        }
+
+                        logger?.error(msg);
+                        reject(error);
+                    } else {
+                        resolve({ stdout, stderr });
+                    }
+                });
+            }
+        );
+    }
+}

src/utils/commonUtils.ts

@@ -10,7 +10,7 @@ import * as sinon from 'sinon';
 import { afterEach, beforeEach } from 'mocha';
 import { BriefcaseCommand } from '../../../../src/commands/wizard/briefcaseCommand';
 import { Uri, l10n, window, Progress, CancellationToken } from 'vscode';
-import { CommonUtils } from '@salesforce/lwc-dev-mobile-core/lib/common/CommonUtils';
+import { CommonUtils } from '../../../../src/utils/commonUtils';
 import { InstructionsWebviewProvider } from '../../../../src/webviews/instructions';
 
 suite('Briefcase Command Test Suite', () => {

test/suite/commands/wizard/briefcaseCommand.test.ts

@@ -10,7 +10,7 @@ import { writeFile } from 'fs/promises';
 import { afterEach, beforeEach } from 'mocha';
 import * as path from 'path';
 import * as process from 'process';
-import { CommonUtils } from '@salesforce/lwc-dev-mobile-core/lib/common/CommonUtils';
+import { CommonUtils } from '../../../../src/utils/commonUtils';
 import * as sinon from 'sinon';
 import { l10n, Uri, window } from 'vscode';
 import {

test/suite/commands/wizard/configureProjectCommand.test.ts

@@ -19,7 +19,7 @@ import {
     DescribeGlobalResult,
     DescribeSObjectResult,
     Field as FieldType
-} from 'jsforce';
+} from '@jsforce/jsforce-node';
 import { CoreExtensionService } from '../../../src/services';
 
 suite('Org Utils Test Suite', () => {