remove unused code

Author: ad-shreya

packages/mcp-provider-devops/src/commitWorkItem.ts

@@ -122,53 +122,8 @@ export async function fetchWorkItems(connection: Connection, projectId: string):
 }
 
 /**
- * Fetches a work item by name using an existing Connection (e.g. from getOrgService().getConnection()).
- * Use this when the caller already has a connection to avoid resolving it twice.
+ * Fetches a work item by name using the given Connection (e.g. from getOrgService().getConnection()).
  */
-export async function fetchWorkItemByNameWithConnection(
-    connection: Connection,
-    workItemName: string
-): Promise<WorkItem | null | any> {
-    try {
-        const query = `
-            SELECT
-                Id,
-                Name,
-                Subject,
-                Description,
-                Status,
-                AssignedToId,
-                SourceCodeRepositoryBranchId,
-                SourceCodeRepositoryBranch.Name,
-                SourceCodeRepositoryBranch.SourceCodeRepositoryId,
-                SourceCodeRepositoryBranch.SourceCodeRepository.Name,
-                SourceCodeRepositoryBranch.SourceCodeRepository.RepositoryOwner,
-                SourceCodeRepositoryBranch.SourceCodeRepository.Provider,
-                DevopsPipelineStageId,
-                DevopsProjectId
-            FROM WorkItem
-            WHERE Name = '${workItemName}'
-            LIMIT 1
-        `;
-
-        const result: any = await connection.query(query);
-        const item = (result?.records || [])[0];
-        if (!item) {
-            return null;
-        }
-
-        const projectId: string = item?.DevopsProjectId;
-        const cache = new Map<string, ProjectStagesContext>();
-        const ctx = await ensureProjectStages(connection, cache, projectId);
-        if (!ctx) {
-            throw new Error(`Pipeline or stages not found for project: ${projectId}`);
-        }
-        return mapRawItemToWorkItem(item, ctx);
-    } catch (error) {
-        throw error;
-    }
-}
-
 export async function fetchWorkItemByName(connection: Connection, workItemName: string): Promise<WorkItem | null | any> {
     try {
         const query = `

packages/mcp-provider-devops/src/getWorkItems.ts

@@ -2,7 +2,7 @@ import { z } from "zod";
 import { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
 import { McpTool, McpToolConfig, ReleaseState, Toolset, Services } from "@salesforce/mcp-provider-api";
 import { createPullRequest } from "../createPullRequest.js";
-import { fetchWorkItemByNameWithConnection } from "../getWorkItems.js";
+import { fetchWorkItemByName } from "../getWorkItems.js";
 import { usernameOrAliasParam } from "../shared/params.js";
 
 const inputSchema = z.object({
@@ -88,7 +88,7 @@ export class CreatePullRequest extends McpTool<InputArgsShape, OutputArgsShape>
         };
       }
       const connection = await this.services.getOrgService().getConnection(input.usernameOrAlias);
-      const workItem = await fetchWorkItemByNameWithConnection(connection, input.workItemName);
+      const workItem = await fetchWorkItemByName(connection, input.workItemName);
 
       if (!workItem || !workItem.id) {
         return {

packages/mcp-provider-devops/src/tools/createPullRequest.ts

@@ -80,10 +80,10 @@ export class SfDevopsPromoteWorkItem extends McpTool<InputArgsShape, OutputArgsS
 
   public async exec(input: InputArgs): Promise<CallToolResult> {
     const startTime = Date.now();
+    const connection = await this.services.getOrgService().getConnection(input.usernameOrAlias);
     let items: any[] | any;
-    
+
     try {
-      const connection = await this.services.getOrgService().getConnection(input.usernameOrAlias);
       items = await fetchWorkItemsByNames(connection, input.workItemNames);
     } catch (e: any) {
       const executionTime = Date.now() - startTime;
@@ -118,7 +118,6 @@ export class SfDevopsPromoteWorkItem extends McpTool<InputArgsShape, OutputArgsS
     }
 
     try {
-      const connection = await this.services.getOrgService().getConnection(input.usernameOrAlias);
       const result = await promoteWorkItems(connection, { workitems: prepared });
 
       const executionTime = Date.now() - startTime;

packages/mcp-provider-devops/src/tools/sfDevopsPromoteWorkItem.ts

@@ -1,5 +1,5 @@
 import { type Connection } from "@salesforce/core";
-import { fetchWorkItemByNameWithConnection } from "./getWorkItems.js";
+import { fetchWorkItemByName } from "./getWorkItems.js";
 
 export type WorkItemStatus = "In Progress" | "Ready to Promote";
 
@@ -31,7 +31,7 @@ export async function updateWorkItemStatus(
   workItemName: string,
   status: WorkItemStatus
 ): Promise<UpdateWorkItemStatusResult> {
-  const workItem = await fetchWorkItemByNameWithConnection(connection, workItemName);
+  const workItem = await fetchWorkItemByName(connection, workItemName);
   if (!workItem?.id) {
     return {
       success: false,