fix(cli): address code review findings #138
salmonumbrellaAnnotations
10 errors
|
test:
internal/cmd/classroom_rosters.go#L547
shadow: declaration of "err" shadows declaration at line 494 (govet)
|
|
test:
internal/cmd/classroom_rosters.go#L529
shadow: declaration of "err" shadows declaration at line 494 (govet)
|
|
test:
internal/cmd/classroom_rosters.go#L522
shadow: declaration of "err" shadows declaration at line 494 (govet)
|
|
test:
internal/cmd/chat_spaces.go#L156
shadow: declaration of "err" shadows declaration at line 133 (govet)
|
|
test:
internal/cmd/classroom_rosters.go#L492
cyclomatic complexity 52 of func `(*ClassroomRosterCmd).Run` is high (> 50) (gocyclo)
|
|
test:
internal/cmd/name_resolution.go#L25
string `@default` has 7 occurrences, make it a constant (goconst)
|
|
test:
internal/cmd/calendar.go#L228
string `primary` has 6 occurrences, make it a constant (goconst)
|
|
test:
internal/cmd/auth_keyring.go#L66
string `auto` has 5 occurrences, but such constant `colorAuto` already exists (goconst)
|
|
test:
internal/cmd/exit_codes_test.go#L95
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
|
|
test:
internal/cmd/exit_codes_test.go#L18
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
|