Skip to content

Commit 03037c3

Browse files
fix: address lint issues in store.go
- Wrap keychain access error for wrapcheck linter - Add blank lines before returns for wsl linter - Define static error for err113 linter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 3e664bf commit 03037c3

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

internal/secrets/store.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@ const (
4343
)
4444

4545
var (
46-
errMissingEmail = errors.New("missing email")
47-
errMissingRefreshToken = errors.New("missing refresh token")
48-
errNoTTY = errors.New("no TTY available for keyring file backend password prompt")
46+
errMissingEmail = errors.New("missing email")
47+
errMissingRefreshToken = errors.New("missing refresh token")
48+
errNoTTY = errors.New("no TTY available for keyring file backend password prompt")
49+
errInvalidKeyringBackend = errors.New("invalid keyring backend")
4950
)
5051

5152
func allowedBackendsFromEnv() ([]keyring.BackendType, error) {
@@ -57,7 +58,7 @@ func allowedBackendsFromEnv() ([]keyring.BackendType, error) {
5758
case "file":
5859
return []keyring.BackendType{keyring.FileBackend}, nil
5960
default:
60-
return nil, fmt.Errorf("invalid %s (expected auto, keychain, or file)", keyringBackendEnv)
61+
return nil, fmt.Errorf("%w: %s (expected auto, keychain, or file)", errInvalidKeyringBackend, keyringBackendEnv)
6162
}
6263
}
6364

@@ -280,10 +281,12 @@ func EnsureKeychainAccess() error {
280281
strings.Contains(errStr, "interaction not allowed") {
281282
return fmt.Errorf("%w\n\nTo unlock manually, run:\n security unlock-keychain ~/Library/Keychains/login.keychain-db", ErrKeychainLocked)
282283
}
283-
return err
284+
285+
return fmt.Errorf("keychain access check failed: %w", err)
284286
}
285287

286288
_ = ks.ring.Remove(testKey)
289+
287290
return nil
288291
}
289292

0 commit comments

Comments
 (0)