fix: resolve lint issues (goconst, govet shadow, noctx, wsl)

- Use strconv.FormatBool in boolString to avoid goconst "true" literal
- Rename shadowed err to writeErr in attachment test
- Use http.NewRequestWithContext in transport test
- Add blank lines before if statements per wsl_v5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: salmonumbrella

internal/cmd/execute_gmail_attachment_test.go

@@ -408,7 +408,7 @@ func TestExecute_GmailAttachment_StaleFileIsRedownloaded(t *testing.T) {
 	newGmailService = func(context.Context, string) (*gmail.Service, error) { return svc, nil }
 
 	outPath := filepath.Join(t.TempDir(), "invoice.pdf")
-	if err := os.WriteFile(outPath, []byte("stale"), 0o600); err != nil {
+	if writeErr := os.WriteFile(outPath, []byte("stale"), 0o600); writeErr != nil {
 		t.Fatalf("WriteFile: %v", err)
 	}
 

internal/cmd/root.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"log/slog"
 	"os"
+	"strconv"
 
 	"github.com/alecthomas/kong"
 
@@ -162,10 +163,7 @@ func envOr(key, fallback string) string {
 }
 
 func boolString(v bool) string {
-	if v {
-		return "true"
-	}
-	return "false"
+	return strconv.FormatBool(v)
 }
 
 func newParser(description string) (*kong.Kong, *CLI, error) {

internal/googleapi/client_more_test.go

@@ -268,24 +268,29 @@ func TestNewBaseTransport_RespectsProxyAndTLSMinimum(t *testing.T) {
 	if transport == nil {
 		t.Fatalf("expected transport")
 	}
+
 	if transport.Proxy == nil {
 		t.Fatalf("expected proxy func")
 	}
+
 	if transport.TLSClientConfig == nil {
 		t.Fatalf("expected TLS config")
 	}
+
 	if transport.TLSClientConfig.MinVersion < tls.VersionTLS12 {
 		t.Fatalf("expected TLS min version >= 1.2, got %d", transport.TLSClientConfig.MinVersion)
 	}
 
-	req, err := http.NewRequest(http.MethodGet, "https://www.googleapis.com", nil)
+	req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, "https://www.googleapis.com", nil)
 	if err != nil {
 		t.Fatalf("new request: %v", err)
 	}
+
 	proxyURL, err := transport.Proxy(req)
 	if err != nil {
 		t.Fatalf("proxy lookup: %v", err)
 	}
+
 	if proxyURL == nil || !strings.Contains(proxyURL.String(), "127.0.0.1:8888") {
 		t.Fatalf("expected HTTPS proxy to be honored, got: %v", proxyURL)
 	}