Skip to content

Commit 40d4355

Browse files
committed
Do not bench spawning the LRU thread
1 parent 0a4b3fd commit 40d4355

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

Diff for: benches/compare.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std::mem::transmute;
33
use codspeed_criterion_compat::{
44
criterion_group, criterion_main, BatchSize, BenchmarkId, Criterion,
55
};
6-
use salsa::Setter;
6+
use salsa::{Database, Setter};
77

88
#[salsa::input]
99
pub struct Input {
@@ -34,13 +34,16 @@ fn mutating_inputs(c: &mut Criterion) {
3434
group.bench_function(BenchmarkId::new("mutating", n), |b| {
3535
b.iter_batched_ref(
3636
|| {
37-
let db = salsa::DatabaseImpl::default();
37+
let mut db = salsa::DatabaseImpl::default();
3838
let base_string = "hello, world!".to_owned();
3939
let base_len = base_string.len();
4040

4141
let string = base_string.clone().repeat(*n);
4242
let new_len = string.len();
4343

44+
// spawn the LRU thread
45+
db.synthetic_write(salsa::Durability::HIGH);
46+
4447
let input = Input::new(&db, base_string.clone());
4548
let actual_len = length(&db, input);
4649
assert_eq!(base_len, actual_len);

Diff for: benches/incremental.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use codspeed_criterion_compat::{criterion_group, criterion_main, BatchSize, Criterion};
2-
use salsa::Setter;
2+
use salsa::{Database, Setter};
33

44
#[salsa::input]
55
struct Input {
@@ -26,7 +26,9 @@ fn many_tracked_structs(criterion: &mut Criterion) {
2626
criterion.bench_function("many_tracked_structs", |b| {
2727
b.iter_batched_ref(
2828
|| {
29-
let db = salsa::DatabaseImpl::new();
29+
let mut db = salsa::DatabaseImpl::new();
30+
// spawn the LRU thread
31+
db.synthetic_write(salsa::Durability::HIGH);
3032

3133
let input = Input::new(&db, 1_000);
3234
let input2 = Input::new(&db, 1);

0 commit comments

Comments
 (0)