From 8f4000d255f7697d453869cf7b6d6d430a93f4ec Mon Sep 17 00:00:00 2001 From: Julian Hundeloh <5358638+jaulz@users.noreply.github.com> Date: Fri, 29 Dec 2023 05:17:09 +0100 Subject: [PATCH 1/4] feat: allow users to pass more options to `createFunction` --- src/operations/functions.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/operations/functions.ts b/src/operations/functions.ts index 44ff6bf9..092b8687 100644 --- a/src/operations/functions.ts +++ b/src/operations/functions.ts @@ -19,8 +19,7 @@ export function dropFunction(mOptions: MigrationOptions) { export function createFunction(mOptions: MigrationOptions) { // eslint-disable-next-line default-param-last const _create: CreateFunction = (functionName, functionParams = [], functionOptions, definition) => { - const { replace, returns = 'void', language, window, behavior = 'VOLATILE', onNull, parallel } = functionOptions - const options = [] + const { replace, returns = 'void', language, window, behavior = 'VOLATILE', onNull, parallel, options = [] } = functionOptions if (behavior) { options.push(behavior) } From a58bc0b5f2bb70e3dbd36e0981ec27f62274c682 Mon Sep 17 00:00:00 2001 From: Julian Hundeloh <5358638+jaulz@users.noreply.github.com> Date: Fri, 29 Dec 2023 05:18:06 +0100 Subject: [PATCH 2/4] fix: add missing type --- src/operations/functionsTypes.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/operations/functionsTypes.ts b/src/operations/functionsTypes.ts index 3113f0e0..16ac5151 100644 --- a/src/operations/functionsTypes.ts +++ b/src/operations/functionsTypes.ts @@ -17,6 +17,7 @@ export interface FunctionOptions { behavior?: 'IMMUTABLE' | 'STABLE' | 'VOLATILE' onNull?: boolean parallel?: 'UNSAFE' | 'RESTRICTED' | 'SAFE' + options?: string[] } type CreateFunctionFn = ( From 1cdeaa05f8b51e700f134099030232f3436a49a6 Mon Sep 17 00:00:00 2001 From: Julian Hundeloh <5358638+jaulz@users.noreply.github.com> Date: Fri, 29 Dec 2023 05:21:52 +0100 Subject: [PATCH 3/4] style: fix lint issues --- src/operations/functions.ts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/operations/functions.ts b/src/operations/functions.ts index 092b8687..715d4cca 100644 --- a/src/operations/functions.ts +++ b/src/operations/functions.ts @@ -19,7 +19,16 @@ export function dropFunction(mOptions: MigrationOptions) { export function createFunction(mOptions: MigrationOptions) { // eslint-disable-next-line default-param-last const _create: CreateFunction = (functionName, functionParams = [], functionOptions, definition) => { - const { replace, returns = 'void', language, window, behavior = 'VOLATILE', onNull, parallel, options = [] } = functionOptions + const { + replace, + returns = 'void', + language, + window, + behavior = 'VOLATILE', + onNull, + parallel, + options = [], + } = functionOptions if (behavior) { options.push(behavior) } From d8383f672c44d1fd5f56e2ac40bf7409bee6faaa Mon Sep 17 00:00:00 2001 From: Julian Hundeloh <5358638+jaulz@users.noreply.github.com> Date: Fri, 29 Dec 2023 05:24:04 +0100 Subject: [PATCH 4/4] style: fix lint issues --- src/operations/functions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operations/functions.ts b/src/operations/functions.ts index 715d4cca..7f43a9b3 100644 --- a/src/operations/functions.ts +++ b/src/operations/functions.ts @@ -19,7 +19,7 @@ export function dropFunction(mOptions: MigrationOptions) { export function createFunction(mOptions: MigrationOptions) { // eslint-disable-next-line default-param-last const _create: CreateFunction = (functionName, functionParams = [], functionOptions, definition) => { - const { + const { replace, returns = 'void', language,