Skip to content

Commit 6cb9c5b

Browse files
committed
fix: add all known missing Salt runtime deps to nox sessions
Salt's package metadata doesn't declare its full dependency tree (they live in requirements/base.txt instead). Expand the list to include jinja2, markupsafe, requests, aiohttp, and pyyaml alongside the previously added looseversion and tornado.
1 parent 0c7655b commit 6cb9c5b

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

noxfile.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,19 @@ def _install_requirements(
113113
finally:
114114
os.unlink(constraints_file.name)
115115

116-
# Salt doesn't properly declare all its runtime dependencies in package metadata,
117-
# so uv doesn't resolve them transitively. Install known missing ones explicitly.
118-
# - looseversion: required by Salt 3006.x
119-
# - tornado: required by Salt 3007.x
120-
session.install(no_progress, "looseversion", "tornado", silent=PIP_INSTALL_SILENT)
116+
# Salt doesn't properly declare all its runtime dependencies in package metadata
117+
# (they are in requirements/base.txt but not in its setup config), so uv doesn't
118+
# resolve them transitively. Install the known missing runtime deps explicitly.
119+
salt_missing_deps = [
120+
"jinja2",
121+
"markupsafe",
122+
"requests",
123+
"looseversion",
124+
"tornado",
125+
"aiohttp",
126+
"pyyaml",
127+
]
128+
session.install(no_progress, *salt_missing_deps, silent=PIP_INSTALL_SILENT)
121129

122130
if install_test_requirements:
123131
install_extras.append("tests")

0 commit comments

Comments
 (0)