feat: add Elasticsearch 9 support with comprehensive test coverage (#22)

- Add elasticsearch9_mod module and returner with full ES 9.x client support
- Add new ES9 API methods: count, mget, delete_by_query, update_by_query,
  reindex, msearch, scroll, clear_scroll, open/close_point_in_time,
  document_update, search, bulk
- Fix dict-mutation-during-iteration crash in returner states_order_output
- Fix event_return() to index each event individually instead of only the last
- Fix search() in both ES8 and ES9 modules to parse JSON string body arguments
- Fix typos in returner error messages and debug log strings
- Normalize ret['data'] into ret['return'] when return is None in returner
- Add comprehensive returner tests (31 tests, 97% coverage)
- Add pyupgrade Python 3.10+ syntax improvements
- Fix Sphinx documentation formatting errors
- Add missing Salt runtime deps (tornado, looseversion) to nox sessions
- Add changelog entry for bug fixes

Author: cesan3

.github/workflows/ci.yml

@@ -158,6 +158,7 @@ jobs:
 
       - name: Delete Exit Status Artifacts
         if: always()
+        continue-on-error: true
         uses: geekyeggo/delete-artifact@7ee91e82b4a7f3339cd8b14beace3d826a2aac39  # v5.1.0
         with:
           name: exitstatus-*

.github/workflows/deploy-docs-action.yml

@@ -58,6 +58,7 @@ jobs:
 
       - name: Delete GitHub Pages artifact
         if: always()
+        continue-on-error: true
         uses: geekyeggo/delete-artifact@7ee91e82b4a7f3339cd8b14beace3d826a2aac39  # v5.1.0
         with:
           name: html-docs-pages

.pre-commit-config.yaml

@@ -119,6 +119,7 @@ repos:
         alias: lint-src
         name: Lint Source Code
         language: python
+        language_version: python3.10
         entry: nox -e lint-code-pre-commit --
         files: ^((setup|noxfile)|src/.*)\.py$
         require_serial: true
@@ -130,6 +131,7 @@ repos:
         alias: lint-tests
         name: Lint Tests
         language: python
+        language_version: python3.10
         entry: nox -e lint-tests-pre-commit --
         files: ^tests/.*\.py$
         require_serial: true

changelog/22.fixed.md

@@ -0,0 +1 @@
+Fixed a crash in the elasticsearch9 returner when `states_order_output` is enabled (dict modified during iteration). Fixed `event_return()` to index each event individually instead of only the last one. Fixed `search()` in both elasticsearch8 and elasticsearch9 modules to parse JSON string `body` arguments before calling `.get()`.

docs/ref/modules/index.rst

@@ -11,3 +11,4 @@ _________________
 
     elasticsearch6_mod
     elasticsearch8_mod
+    elasticsearch9_mod

docs/ref/modules/saltext.elasticsearch.modules.elasticsearch9_mod.rst

@@ -0,0 +1,5 @@
+``elasticsearch``
+=================
+
+.. automodule:: saltext.elasticsearch.modules.elasticsearch9_mod
+    :members:

docs/ref/returners/index.rst

@@ -11,3 +11,4 @@ ________________
 
     elasticsearch6_mod
     elasticsearch8_mod
+    elasticsearch9_mod

docs/ref/returners/saltext.elasticsearch.returners.elasticsearch9_mod.rst

@@ -0,0 +1,5 @@
+``elasticsearch``
+=================
+
+.. automodule:: saltext.elasticsearch.returners.elasticsearch9_mod
+    :members:

noxfile.py

@@ -113,6 +113,20 @@ def _install_requirements(
             finally:
                 os.unlink(constraints_file.name)
 
+            # Salt doesn't properly declare all its runtime dependencies in package metadata
+            # (they are in requirements/base.txt but not in its setup config), so uv doesn't
+            # resolve them transitively. Install the known missing runtime deps explicitly.
+            salt_missing_deps = [
+                "jinja2",
+                "markupsafe",
+                "requests",
+                "looseversion",
+                "tornado",
+                "aiohttp",
+                "pyyaml",
+            ]
+            session.install(no_progress, *salt_missing_deps, silent=PIP_INSTALL_SILENT)
+
         if install_test_requirements:
             install_extras.append("tests")
 

pyproject.toml

@@ -89,7 +89,7 @@ tests = [
 [tool.uv]
 # Salt's legacy setup.py requires old setuptools.
 # Since uv 0.6.0, it does not fall back to reading requirements from egg-info.
-build-constraint-dependencies = ["setuptools<69"]
+constraint-dependencies = ["setuptools<69"]
 
 [tool.setuptools]
 zip-safe = false