[TECH DEBT] Need tests for existing modules

[nicholasmhughes]

Description of the tech debt to be addressed, include links and screenshots

It seems these modules were created back in 2016 before there were stricter requirements for tests. The test framework is in place with some boilerplate, but we need to get some actual test code to cover the existing functionality.

[vipermark7]

Interested in taking this on! I'll start with the utils/ folder

[vipermark7]

Would we want to use PyTest for this?

I'm unsure what the wider Python community uses. I think it would be a good option since in seems to come with handy mocking features :)

[nicholasmhughes]

Hello @vipermark7 ! Yes, the Salt Extensions expect to use nox to call pytest so the tests should be written in that fashion. You can look at some of the other Extensions which have tests for examples on how to structure them. If you have any additional questions, feel free to ask!

[vipermark7]

I got a new unit test to pass locally! I thinkk I'll need write access to push it to my new branch though

[nicholasmhughes]

Great! Regarding contribution workflow, we use the Fork-and-Branch Workflow that is prevalent in OSS. So, you should be able to fork the repo, create a branch in your fork to hold and changes, and then open a PR to merge your branch into main back in this repository.

[vipermark7]

Oh, OK, thanks! That occurred to me as soon as I posted my comment x(

…

On Wed, Feb 7, 2024, 3:07 PM Nicholas Hughes ***@***.***> wrote: Great! Regarding contribution workflow, we use the Fork-and-Branch Workflow <https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/> that is prevalent in OSS. So, you should be able to fork the repo, create a branch in your fork to hold and changes, and then open a PR to merge your branch into main back in this repository. — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACKMZRFEX44UGIVXAG7AUBLYSPNJFAVCNFSM6AAAAABBZASVNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSG44DEOJZGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>