resolve review comments

Author: djivey

changelog/+config.removed.md

@@ -0,0 +1 @@
+Removed the ability to override minion configuration in function parameters (`context`, `kubeconfig`, `kubeconfig_data`)

changelog/+context.breaking.md

@@ -0,0 +1 @@
+Reused the removed parameter for Jinja2 context variables! Take care when upgrading from earlier versions.

changelog/10.added.md

@@ -1,43 +1 @@
-# Added Comprehensive Testing Suite and Enhanced State Module Functionality
-
-Renamed the state module kubernetesmod to kubernetes due to a conflict with the salt core state module kubernetes
-
-## Testing Infrastructure
-Implemented pytest-based testing framework with pytest-kind
-Added pytest fixtures for handling Kubernetes resources:
-  - Template management
-  - Configurable Kubernetes version testing
-
-## Resource Management Tests
-Added functional and integration tests covering:
-  - Namespace management (creation, deletion, templating)
-  - Pod lifecycle (creation, deletion, template support)
-  - Deployment operations (creation, updates, deletion)
-  - Secret handling (creation, updates, base64 encoding)
-  - Service configuration (ports, selectors, types)
-  - ConfigMap management (data handling, updates)
-  - Node label operations (single labels and folder-based management)
-
-## Template Support
-Added Jinja2 template support for all resource types
-Implemented context-based resource creation:
-  - Namespace templates with label support
-  - Pod templates with container configuration
-  - Deployment templates with replica and selector support
-  - Service templates with flexible port configuration
-  - ConfigMap templates with multi-line data support
-  - Secret templates with data encoding support
-
-## Spec Validation Enhancements
-  - Base64 encoding validation for secrets
-  - Service port configuration validation
-  - ConfigMap data consistency checks
-  - Namespace state validation
-  - Deployment spec verification
-  - Container configuration validation
-
-## Documentation
-Added detailed docstrings for all test functions
-  - Included usage examples in test cases
-  - Documented template structures and context usage
-  - Added comments explaining complex operations
+Added support for specifying template context variables and improved spec validation.

noxfile.py

@@ -290,7 +290,7 @@ def _lint(session, rcfile, flags, paths, tee_output=True):
             stdout.seek(0)
             contents = stdout.read()
             if contents:
-                contents.decode("utf-8")
+                contents = contents.decode("utf-8")
                 sys.stdout.write(contents)
                 sys.stdout.flush()
                 if pylint_report_path:

pyproject.toml

@@ -36,8 +36,6 @@ dynamic = ["version"]
 dependencies = [
     "salt>=3006",
     "kubernetes>=19.15.0; platform_system == 'Linux'",
-    "PyYAML>=5.3.1",
-    "docker>=6.0.0",
 ]
 
 [project.readme]
@@ -73,14 +71,12 @@ lint = [
 ]
 tests = [
     "pytest>=7.2.0",
-    "pytest-salt-factories>=1.0.0rc19",
+    "pytest-salt-factories>=1.0.0; sys_platform == 'win32'",
+    "pytest-salt-factories[docker]>=1.0.0; sys_platform != 'win32'",
+    "kubernetes>=19.15.0",
     "pytest-helpers-namespace>=2019.1.8",
     "pytest-subtests",
     "pytest-timeout",
-    "kubernetes>=19.15.0",
-    "PyYAML>=5.3.1",
-    "mock>=4.0.3",
-    "pytest-custom-exit-code>=0.3",
     "pytest-kind>=22.8.0",
     "cryptography>=42.0.0",
 ]