s3:libads: Set NT_STATUS_UNSUCCESSFUL for IP address entry

cryptomilk · Bjoern Jacke · commit 0a6726fb8346 · 2026-02-07T16:14:24.000Z
This is what we do in libads/ldap.c too. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15975 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org> (cherry picked from commit 9e1bcf8) Autobuild-User(v4-24-test): Björn Jacke <bjacke@samba.org> Autobuild-Date(v4-24-test): Sat Feb 7 16:14:24 UTC 2026 on atb-devel-224
diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
@@ -1264,7 +1264,10 @@ static char *get_kdc_ip_string(char *mem_ctx,
 				cldap_reply->pdc_dns_name);
 			if (has_entry) {
 				/* propagate blacklisting from name to ip */
-				add_failed_connection_entry(realm, addr, status);
+				add_failed_connection_entry(
+					realm,
+					addr,
+					NT_STATUS_UNSUCCESSFUL);
 				continue;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -1264,7 +1264,10 @@ static char get_kdc_ip_string(char mem_ctx,`
`1264`	`1264`	`cldap_reply->pdc_dns_name);`
`1265`	`1265`	`if (has_entry) {`
`1266`	`1266`	`/* propagate blacklisting from name to ip */`
`1267`		`- add_failed_connection_entry(realm, addr, status);`
	`1267`	`+ add_failed_connection_entry(`
	`1268`	`+ realm,`
	`1269`	`+ addr,`
	`1270`	`+ NT_STATUS_UNSUCCESSFUL);`
`1268`	`1271`	`continue;`
`1269`	`1272`	`}`
`1270`	`1273`	`}`