Skip to content

There is no use of the --plyr-font-smoothing variable inside CSS source code #2873

@babakfp

Description

@babakfp

Inside plyr.css you can't find --plyr-font-smoothing getting used at all.

In SCSS code, we can see this:

$plyr-font-smoothing: var(--plyr-font-smoothing, false) !default;

and this:

@mixin plyr-font-smoothing($mode: true) {
@if $mode {

This isn't valid code, because the current default value is a string, so it's always true.

So, the whole thing is useless. What to do, just make it the default and remove variables.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions