Skip to content

Plyr Sass uses deprecated @import and global functions (breaks in Dart Sass 3.0) #2877

@jimblue

Description

@jimblue

Expected behaviour

Plyr’s Sass files should compile without deprecation warnings when using the latest Dart Sass, and should be compatible with the upcoming Dart Sass 3.0.0 (which removes @import and several global-function aliases).

Actual behaviour

When compiling Plyr’s Sass from src/sass/ using Dart Sass, multiple deprecation warnings appear:

  • Deprecated @import rules
  • Deprecated global built-in functions (e.g. length(), nth(), str-length(), str-slice())
  • Warnings coming from plyr.scss, css-vars.scss, and multiple files inside settings/

These warnings fill the console and will become errors once Dart Sass 3.0.0 is released.

Steps to reproduce

  1. Install Dart Sass (or use any toolchain bundling it, e.g. Vite, Webpack, Gulp).
  2. Import Plyr Sass directly.
  3. Run the Sass compiler.
  4. Observe deprecation warnings.

Environment

  • Browser: N/A (build-time issue)
  • Version: Latest Plyr version (as of today)
  • Operating System: macOS
  • Version: 10.15.7
  • Sass: Dart Sass latest

Console errors

Compiler outputs warnings such as:

Deprecation Warning [import]: Sass @import rules are deprecated…
Deprecation Warning [global-builtin]: Global built-in functions are deprecated…

Link to where the bug is happening

Not related to runtime, happens during Sass compilation. A minimal reproduction can be made with any Sass build setup simply importing Plyr’s Sass entrypoint.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions