Merge pull request #130 from samschott/remove-nsusernotificationcenter-support

Remove macos legacy backend

Author: samschott

src/desktop_notifier/macos_legacy.py

@@ -18,7 +18,6 @@
 
 
 __all__ = [
-    "is_bundle",
     "is_signed_bundle",
     "macos_version",
 ]
@@ -39,18 +38,6 @@
 kSecCSStrictValidate = 1 << 4
 
 
-def is_bundle() -> bool:
-    """
-    Detect if we are in an app bundle / framework.
-
-    :returns: Whether we are inside a valid app bundle or framework.
-    """
-
-    main_bundle = NSBundle.mainBundle
-
-    return main_bundle.bundleIdentifier is not None
-
-
 def is_signed_bundle() -> bool:
     """
     Detect if we are in a signed app bundle / framework.

src/desktop_notifier/macos_support.py

@@ -59,41 +59,24 @@ def get_implementation() -> Type[DesktopNotifierBase]:
     :raises RuntimeError: when passing ``macos_legacy = True`` on macOS 12.0 and later.
     """
     if platform.system() == "Darwin":
-        from .macos_support import is_bundle, is_signed_bundle, macos_version
+        from .macos_support import is_signed_bundle, macos_version
 
         has_unusernotificationcenter = macos_version >= Version("10.14")
-        has_nsusernotificationcenter = macos_version < Version("12.0")
         is_signed = is_signed_bundle()
 
         if has_unusernotificationcenter and is_signed:
             # Use modern UNUserNotificationCenter.
             from .macos import CocoaNotificationCenter
 
             return CocoaNotificationCenter
-
-        elif has_nsusernotificationcenter and is_bundle():
-            if has_unusernotificationcenter and not is_signed:
+        else:
+            if has_unusernotificationcenter:
                 logger.warning(
-                    "Running outside of a signed Framework or bundle: "
-                    "falling back to NSUserNotificationCenter"
+                    "Notification Center can only be used "
+                    "from a signed Framework or app bundle"
                 )
             else:
-                logger.warning(
-                    "Running on macOS 10.13 or earlier: "
-                    "falling back to NSUserNotificationCenter"
-                )
-
-            # Use deprecated NSUserNotificationCenter.
-            from .macos_legacy import CocoaNotificationCenterLegacy
-
-            return CocoaNotificationCenterLegacy
-
-        else:
-            # Use dummy backend.
-            logger.warning(
-                "Notification Center can only be used "
-                "from a signed Framework or app bundle"
-            )
+                logger.warning("Only macOS 10.14 and later are supported")
 
             from .dummy import DummyNotificationCenter