Merge pull request #135 from samuelzedec/develop

fix: Correções de Issues do SonarCloud

Author: samuelzedec

analyze.sh

@@ -44,8 +44,8 @@ SONAR_BEGIN_ARGS=(
 **/appsettings*.json,\
 **/Dockerfile*,\
 **/Seeders/**,\
-**/Schedulers/**,\,
-**/Templates/**,\
+**/Schedulers/**,\
+**/*.html,\
 **/Mappings/**"
   /d:sonar.coverage.exclusions="\
 **/Migrations/**,\

src/Riber.Infrastructure/Services/AI/Models/AiProductService.cs

@@ -12,7 +12,7 @@ public sealed class AiProductService(AppDbContext context)
 {
     public override async Task<ReadOnlyMemory<Product>> FindSimilarAsync(
         float[] query,
-        CancellationToken cancellationToken)
+        CancellationToken cancellationToken = default)
     {
         var products = await _table
             .AsNoTracking()
@@ -27,6 +27,6 @@ public override async Task<ReadOnlyMemory<Product>> FindSimilarAsync(
 
     public override async Task<ProductEmbeddingsModel?> GetByEntityIdAsync(
         Guid entityId,
-        CancellationToken cancellationToken)
+        CancellationToken cancellationToken = default)
         => await _table.LastOrDefaultAsync(p => p.ProductId == entityId, cancellationToken);
 }

tests/Riber.Infrastructure.Tests/Services/Authentication/PermissionDataServiceTests.cs

@@ -10,11 +10,12 @@
 using Riber.Infrastructure.Persistence.Identity;
 using Riber.Api.Tests;
 using Riber.Api.Tests.Fixtures;
+using Riber.Infrastructure.Services.Authentication;
 
 namespace Riber.Infrastructure.Tests.Services.Authentication;
 
 public sealed class PermissionDataServiceTests(
-    WebAppFixture webAppFixture, 
+    WebAppFixture webAppFixture,
     DatabaseFixture databaseFixture)
     : IntegrationTestBase(webAppFixture, databaseFixture)
 {
@@ -104,7 +105,7 @@ public async Task UpdatePermissionStatusAsync_WhenPermissionExists_ShouldToggleI
 
         // Assert
         result.IsSuccess.Should().BeTrue();
-        
+
         var updatedPermission = await context.Set<ApplicationPermission>()
             .FirstAsync(p => p.Name == permission.Name);
         updatedPermission.IsActive.Should().BeTrue();
@@ -155,8 +156,8 @@ public async Task GetAllWithDescriptionsAsync_WhenCalled_ShouldReturnAllPermissi
 
     #region Helper Methods
 
-    private IPermissionDataService CreatePermissionService(AppDbContext context)
-        => new Infrastructure.Services.Authentication.PermissionDataService(context, _mockMemoryCache.Object);
+    private PermissionDataService CreatePermissionService(AppDbContext context)
+        => new(context, _mockMemoryCache.Object);
 
     private ApplicationPermission CreatePermission(string name, bool isActive = true)
         => new()
@@ -169,16 +170,18 @@ private ApplicationPermission CreatePermission(string name, bool isActive = true
         };
 
     private List<ApplicationPermission> CreatePermissions(int count)
-        => Enumerable.Range(1, count)
-            .Select(i => new ApplicationPermission
-            {
-                Id = _faker.Random.UInt(),
-                Name = $"permission-{i}",
-                Description = _faker.Random.String2(10),
-                IsActive = _faker.Random.Bool(),
-                Category = "test"
-            })
-            .ToList();
+        =>
+        [
+            .. Enumerable.Range(1, count)
+                .Select(i => new ApplicationPermission
+                {
+                    Id = _faker.Random.UInt(),
+                    Name = $"permission-{i}",
+                    Description = _faker.Random.String2(10),
+                    IsActive = _faker.Random.Bool(),
+                    Category = "test"
+                })
+        ];
 
     private void SetupCacheMiss()
     {