refactor: Refactoring in user creation and database indexes

Author: samuelzedec

src/SnackFlow.Application/Abstractions/Services/IAuthService.cs

@@ -40,6 +40,20 @@ public interface IAuthService
     /// <returns>Um objeto <see cref="UserDetailsDTO"/> contendo informações detalhadas do usuário se encontrado, ou null se o usuário não existir.</returns>
     Task<UserDetailsDTO?> FindByEmailAsync(string email);
 
+    /// <summary>
+    /// Busca um usuário no sistema com base no nome de usuário fornecido.
+    /// </summary>
+    /// <param name="userName">O nome de usuário do usuário que está sendo pesquisado no sistema.</param>
+    /// <returns>Uma tarefa que, quando concluída, contém as informações detalhadas do usuário na forma de um <see cref="UserDetailsDTO"/>, ou null se o usuário não for encontrado.</returns>
+    Task<UserDetailsDTO?> FindByUserNameAsync(string userName);
+
+    /// <summary>
+    /// Busca e retorna os detalhes de um usuário com base no número de telefone fornecido.
+    /// </summary>
+    /// <param name="phoneNumber">O número de telefone do usuário a ser buscado.</param>
+    /// <returns>Uma tarefa que representa a operação assíncrona. O resultado contém os detalhes do usuário, ou null se nenhum usuário for encontrado.</returns>
+    Task<UserDetailsDTO?> FindByPhoneAsync(string phoneNumber);
+
     /// <summary>
     /// Atribui uma função ao usuário com base na posição empresarial especificada.
     /// </summary>

src/SnackFlow.Application/Exceptions/ApplicationException.cs

@@ -1,6 +1,6 @@
 namespace SnackFlow.Application.Exceptions;
 
-public class ApplicationException(string message, int code) : Exception(message)
+public abstract class ApplicationException(string message, int code) : Exception(message)
 {
-    public int Code { get; } = code;
+    public int Code => code;
 }

src/SnackFlow.Application/Exceptions/AuthenticationServiceException.cs

@@ -0,0 +1,6 @@
+using System.Net;
+
+namespace SnackFlow.Application.Exceptions;
+
+public sealed class AuthenticationServiceException(string message) 
+    : ApplicationException(message, (int)HttpStatusCode.InternalServerError);

src/SnackFlow.Application/Exceptions/ConflictException.cs

@@ -2,5 +2,5 @@
 
 namespace SnackFlow.Application.Exceptions;
 
-public class ConflictException(string message) 
+public sealed class ConflictException(string message) 
     : ApplicationException(message, (int)HttpStatusCode.Conflict);

src/SnackFlow.Application/Exceptions/NotFoundException.cs

@@ -2,5 +2,5 @@
 
 namespace SnackFlow.Application.Exceptions;
 
-public class NotFoundException(string message)
+public sealed class NotFoundException(string message)
     : ApplicationException(message, (int)HttpStatusCode.NotFound);

src/SnackFlow.Application/Exceptions/RequestTimeoutException.cs

@@ -2,5 +2,5 @@
 
 namespace SnackFlow.Application.Exceptions;
 
-public class RequestTimeoutException(string requestName, TimeSpan elapsedTime)
+public sealed class RequestTimeoutException(string requestName, TimeSpan elapsedTime)
     : ApplicationException($"Request '{requestName}' timed out after {elapsedTime.TotalSeconds:F1} seconds", (int)HttpStatusCode.RequestTimeout);

src/SnackFlow.Application/Exceptions/ValidationException.cs

@@ -4,7 +4,7 @@
 
 namespace SnackFlow.Application.Exceptions;
 
-public class ValidationException(IEnumerable<ValidationError> errors) 
+public sealed class ValidationException(IEnumerable<ValidationError> errors) 
     : ApplicationException("One or more validation errors occurred", (int)HttpStatusCode.BadRequest)
 {
     public IEnumerable<ValidationError> Errors => errors;

src/SnackFlow.Application/Features/Users/Commands/CreateUser/CreateUserCommandHandler.cs

@@ -4,6 +4,7 @@
 using SnackFlow.Application.Abstractions.Services;
 using SnackFlow.Application.Common;
 using SnackFlow.Application.DTOs;
+using SnackFlow.Application.Exceptions;
 using SnackFlow.Domain.Constants;
 using SnackFlow.Domain.Entities;
 using SnackFlow.Domain.Repositories;
@@ -18,20 +19,19 @@ internal sealed class CreateUserCommandHandler(
     ILogger<CreateUserCommandHandler> logger)
     : ICommandHandler<CreateUserCommand, CreateUserCommandResponse>
 {
-    public async ValueTask<Result<CreateUserCommandResponse>> Handle(CreateUserCommand command, CancellationToken cancellationToken)
+    public async ValueTask<Result<CreateUserCommandResponse>> Handle(CreateUserCommand command,
+        CancellationToken cancellationToken)
     {
         using var transaction = new TransactionScope(
             TransactionScopeOption.Required,
-            new TransactionOptions
-            {
-                IsolationLevel = IsolationLevel.ReadCommitted,
-                Timeout = TimeSpan.FromMinutes(1)
-            },
+            new TransactionOptions { IsolationLevel = IsolationLevel.ReadCommitted, Timeout = TimeSpan.FromMinutes(1) },
             TransactionScopeAsyncFlowOption.Enabled
         );
 
         try
         {
+            await VerifyIfUserExists(command);
+
             var domainUser = User.Create(
                 fullName: command.FullName,
                 taxId: command.TaxId,
@@ -48,21 +48,49 @@ public async ValueTask<Result<CreateUserCommandResponse>> Handle(CreateUserComma
                 PhoneNumber = Phone.Create(command.PhoneNumber).Value,
                 UserDomainId = domainUser.Id
             };
-            
+
             await unitOfWork.Users.CreateAsync(domainUser, cancellationToken);
             await unitOfWork.SaveChangesAsync(cancellationToken);
             await authService.CreateAsync(applicationUser, cancellationToken);
             transaction.Complete();
-            
+
             return new CreateUserCommandResponse(
                 command.UserName,
                 command.Email
             );
         }
+        catch (ConflictException)
+        {
+            throw;
+        }
         catch (Exception ex)
         {
             logger.LogError(ex, ErrorMessage.Exception.Unexpected(ex.GetType().Name, ex.Message));
             throw;
         }
     }
+
+    private async Task VerifyIfUserExists(CreateUserCommand command)
+    {
+        Task<UserDetailsDTO?>[] userTasks =
+        [
+            authService.FindByEmailAsync(command.Email),
+            authService.FindByUserNameAsync(command.UserName),
+            authService.FindByPhoneAsync(command.PhoneNumber)
+        ];
+
+        var results = await Task.WhenAll(userTasks);
+        
+        if (results[0] is not null) 
+            throw new ConflictException(ErrorMessage.Conflict.EmailAlreadyExists);
+        
+        if (results[1] is not null) 
+            throw new ConflictException(ErrorMessage.Conflict.UserNameAlreadyExists);
+        
+        if (results[2] is not null) 
+            throw new ConflictException(ErrorMessage.Conflict.PhoneAlreadyExists);
+        
+        if (await unitOfWork.Users.ExistsAsync(x => x.TaxId.Value == command.TaxId)) 
+            throw new ConflictException(ErrorMessage.Conflict.TaxIdAlreadyExists);
+    }
 }

src/SnackFlow.Domain/Constants/ErrorMessage.cs

@@ -84,6 +84,8 @@ public static class Conflict
         public const string PhoneAlreadyExists = "Telefone já cadastrado no sistema";
         public const string TaxIdAlreadyExists = "CPF/CNPJ já cadastrado no sistema";
         public const string CorporateNameAlreadyExists = "Nome da empresa já cadastrado no sistema";
+        public const string UserNameAlreadyExists = "Nome de usuário já cadastrado no sistema";
+        public const string FullNameAlreadyExists = "Nome compleco já cadastrado no sistema";
     }
 
     /// <summary>

src/SnackFlow.Infrastructure/Persistence/Mappings/Identity/ApplicationRoleMap.cs

@@ -9,6 +9,10 @@ public sealed class ApplicationRoleMap : IEntityTypeConfiguration<ApplicationRol
     public void Configure(EntityTypeBuilder<ApplicationRole> builder)
     {
         builder.ToTable("aspnet_role");
+        
+        builder
+            .HasKey(u => u.Id)
+            .HasName("pk_aspnet_role_id");
 
         builder
             .Property(r => r.Id)