Merge pull request #120 from samuelzedec/develop

tests: Configuração de alguns testes de integração para o endpoint de login

Author: samuelzedec

Riber.slnx

@@ -9,15 +9,15 @@
     <File Path="CHANGELOG.md"/>
   </Folder>
   <Folder Name="/src/">
-    <Project Path="src\Riber.Api\Riber.Api.csproj" />
-    <Project Path="src\Riber.Application\Riber.Application.csproj" />
-    <Project Path="src\Riber.Domain\Riber.Domain.csproj" />
-    <Project Path="src\Riber.Infrastructure\Riber.Infrastructure.csproj" />
+    <Project Path="src/Riber.Api/Riber.Api.csproj" />
+    <Project Path="src/Riber.Application/Riber.Application.csproj" />
+    <Project Path="src/Riber.Domain/Riber.Domain.csproj" />
+    <Project Path="src/Riber.Infrastructure/Riber.Infrastructure.csproj" />
   </Folder>
   <Folder Name="/tests/">
     <Project Path="tests/Riber.Api.Tests/Riber.Api.Tests.csproj" />
-    <Project Path="tests\Riber.Application.Tests\Riber.Application.Tests.csproj" />
-    <Project Path="tests\Riber.Domain.Tests\Riber.Domain.Tests.csproj" />
-    <Project Path="tests\Riber.Infrastructure.Tests\Riber.Infrastructure.Tests.csproj" />
+    <Project Path="tests/Riber.Application.Tests/Riber.Application.Tests.csproj" />
+    <Project Path="tests/Riber.Domain.Tests/Riber.Domain.Tests.csproj" />
+    <Project Path="tests/Riber.Infrastructure.Tests/Riber.Infrastructure.Tests.csproj" />
   </Folder>
 </Solution>

src/Riber.Api/Common/Api/BuilderExtension.cs

@@ -1,4 +1,5 @@
 using System.Text;
+using System.Text.Json;
 using System.Text.Json.Serialization;
 using Asp.Versioning;
 using Microsoft.AspNetCore.Authorization;
@@ -21,6 +22,7 @@ public static class BuilderExtension
 {
     public static void AddPipeline(this WebApplicationBuilder builder)
     {
+        builder.AddJsonConfiguration();
         builder.AddDocumentationApi();
         builder.AddDependencyInjection();
         builder.AddConfigurations();
@@ -42,7 +44,6 @@ private static void AddMiddleware(this WebApplicationBuilder builder)
     private static void AddConfigurations(this WebApplicationBuilder builder)
     {
         builder.Configuration.AddEnvironmentVariables();
-        builder.Services.AddControllers();
         builder.Services.AddExceptionHandler<GlobalExceptionHandler>();
         builder.Services.AddProblemDetails();
         builder.Services.AddMemoryCache();
@@ -181,4 +182,25 @@ private static void AddDocumentationApi(this WebApplicationBuilder builder)
                 return Task.CompletedTask;
             }));
     }
+
+    private static void AddJsonConfiguration(this WebApplicationBuilder builder)
+    {
+        builder.Services.ConfigureHttpJsonOptions(options =>
+        {
+            options.SerializerOptions.PropertyNamingPolicy = JsonNamingPolicy.CamelCase;
+            options.SerializerOptions.PropertyNameCaseInsensitive = true;
+            options.SerializerOptions.ReadCommentHandling = JsonCommentHandling.Skip;
+            options.SerializerOptions.AllowTrailingCommas = true;
+            options.SerializerOptions.WriteIndented = true;
+            options.SerializerOptions.DefaultIgnoreCondition = JsonIgnoreCondition.Never;
+        });
+
+        builder.Services.AddControllers()
+            .AddJsonOptions(options =>
+            {
+                options.JsonSerializerOptions.PropertyNamingPolicy = JsonNamingPolicy.CamelCase;
+                options.JsonSerializerOptions.PropertyNameCaseInsensitive = true;
+                options.JsonSerializerOptions.DefaultIgnoreCondition = JsonIgnoreCondition.Never;
+            });
+    }
 }

src/Riber.Api/Common/Api/GlobalExceptionHandler.cs

@@ -30,22 +30,9 @@ public async ValueTask<bool> TryHandleAsync(
         };
 
         await httpContext.WriteUnauthorizedResponse(
-            title: GetErrorCode(statusCode),
             code: statusCode,
             messages: messages
         );
         return true;
     }
-    
-    private static string GetErrorCode(int statusCode) => statusCode switch
-    {
-        400 => "BAD_REQUEST",
-        401 => "UNAUTHORIZED",
-        404 => "NOT_FOUND", 
-        408 => "REQUEST_TIMEOUT",
-        409 => "CONFLICT",
-        422 => "UNPROCESSABLE_ENTITY",
-        500 => "INTERNAL_SERVER_ERROR",
-        _ => "APPLICATION_ERROR"
-    };
 }

src/Riber.Api/Controllers/CompanyController.cs

@@ -28,7 +28,7 @@ public async Task<IActionResult> CreateCompany(
         CancellationToken cancellationToken)
     {
         var response = await mediator.Send(withAdminCommand, cancellationToken);
-        return Created($"/api/company/{response.Value.CompanyId}", response);
+        return Created($"/api/company/{response.Value?.CompanyId}", response);
     }
 
     [HttpPut]

src/Riber.Api/Controllers/UserController.cs

@@ -24,6 +24,6 @@ public async Task<IActionResult> CreateUser(
         CancellationToken cancellationToken)
     {
         var response = await mediator.Send(command, cancellationToken);
-        return Created($"/api/user/{response.Value.Email}", response);
+        return Created($"/api/user/{response.Value?.Email}", response);
     }
 }

src/Riber.Api/Extensions/HttpContextExtension.cs

@@ -15,20 +15,27 @@ public static class HttpContextExtension
 
     public static async Task WriteUnauthorizedResponse(
         this HttpContext context,
-        string title,
         int code,
         params string[] messages)
     {
-        var result = Result.Failure(new Error(title, messages));
-        var response = new
-        {
-            isSuccess = result.IsSuccess,
-            error = new { code = result.Error.Code, messages }
-        };
+        var jsonResponse = JsonSerializer.Serialize(
+            Result.Failure<object>(new Error(GetErrorCode(code), messages)), JsonOptions);
 
-        var jsonResponse = JsonSerializer.Serialize(response, JsonOptions);
         context.Response.StatusCode = code;
         context.Response.ContentType = "application/json";
+
         await context.Response.WriteAsync(jsonResponse);
     }
+
+    private static string GetErrorCode(int statusCode) => statusCode switch
+    {
+        400 => "BAD_REQUEST",
+        401 => "UNAUTHORIZED",
+        404 => "NOT_FOUND",
+        408 => "REQUEST_TIMEOUT",
+        409 => "CONFLICT",
+        422 => "UNPROCESSABLE_ENTITY",
+        500 => "INTERNAL_SERVER_ERROR",
+        _ => "APPLICATION_ERROR"
+    };
 }

src/Riber.Api/Middlewares/SecurityStampMiddleware.cs

@@ -24,7 +24,6 @@ public async Task InvokeAsync(HttpContext context, RequestDelegate next)
         {
             logger.LogError("Valores: userId = {UserId}, securityStamp = {TokenSecurityStamp}", userId, tokenSecurityStamp);
             await context.WriteUnauthorizedResponse(
-                "Acesso não autorizado",
                 StatusCodes.Status401Unauthorized,
                 "Token do usuário inválido ou mal formado."
             );
@@ -36,7 +35,6 @@ await context.WriteUnauthorizedResponse(
         if (user is null || user.SecurityStamp != tokenSecurityStamp)
         {
             await context.WriteUnauthorizedResponse(
-                title: "Acesso não autorizado",
                 code: StatusCodes.Status401Unauthorized,
                 messages: "Security stamp inválido ou usuário não encontrado."
             );

src/Riber.Application/Common/Result.cs

@@ -1,47 +1,66 @@
-using System.Diagnostics.CodeAnalysis;
+using System.Text.Json.Serialization;
 using Riber.Domain.Abstractions;
 
 namespace Riber.Application.Common;
 
 public class Result
 {
+    #region Properties
+
+    [JsonInclude] public bool IsSuccess { get; init; }
+    [JsonInclude] public Error Error { get; init; } = new();
+
+    #endregion
+
+    #region Constructors
+
+    [JsonConstructor]
+    protected Result() { }
+
     protected Result(bool isSuccess, Error error)
     {
-        switch (isSuccess)
-        {
-            case true when error != Error.None:
-            case false when error == Error.None:
-                throw new InvalidOperationException();
-
-            default:
-                IsSuccess = isSuccess;
-                Error = error;
-                break;
-        }
+        IsSuccess = isSuccess;
+        Error = error;
     }
 
-    public bool IsSuccess { get; }
-    public Error Error { get; }
+    #endregion
 
-    public static Result Success() => new(true, Error.None);
-    public static Result<T> Success<T>(T value) => new(value, true, Error.None);
+    #region Static Methods
 
-    public static Result Failure(Error error) => new(false, error);
+    public static Result<object> Success() => new(null, true, new Error());
+    public static Result<T> Success<T>(T value) => new(value, true, new Error());
     public static Result<T> Failure<T>(Error error) => new(default, false, error);
 
-    public static Result<T> Create<T>(T? value) =>
-        value is not null ? Success(value) : Failure<T>(Error.NullValue);
+    protected static Result<T> Create<T>(T? value) =>
+        value is not null ? Success(value) : Failure<T>(new Error());
+
+    #endregion
 }
 
 public class Result<T> : Result
 {
-    private readonly T? _value;
+    #region Properties
+
+    [JsonInclude]
+    [JsonIgnore(Condition = JsonIgnoreCondition.Never)]
+    public T? Value { get; init; }
+
+    #endregion
+
+    #region Constructors
+
+    [JsonConstructor]
+    protected Result() { }
 
     protected internal Result(T? value, bool isSuccess, Error error) : base(isSuccess, error)
-        => _value = value;
+        => Value = value;
+
+    #endregion
+
+    #region Overrides
 
-    [NotNull]
-    public T Value => _value! ?? throw new InvalidOperationException("Result has no value");
+    public static implicit operator Result<T>(T? value)
+        => Create(value);
 
-    public static implicit operator Result<T>(T? value) => Create(value);
+    #endregion
 }

src/Riber.Domain/Abstractions/Error.cs

@@ -1,12 +1,29 @@
-namespace Riber.Domain.Abstractions;
+using System.Text.Json.Serialization;
+
+namespace Riber.Domain.Abstractions;
 
 /// <summary>
 /// Representa um erro com um código identificador e uma mensagem descritiva.
 /// </summary>
-/// <param name="Code">Código único que identifica o tipo de erro.</param>
-/// <param name="Messages">Mensagens descritivas e legível sobre os errors.</param>
-public record Error(string Code, params string[] Messages)
+public sealed class Error
 {
-    public static readonly Error None = new(string.Empty);
-    public static readonly Error NullValue = new("Error.NullValue", "Um valor nulo foi fornecido!");
+    #region Properties
+
+    public string Code { get; init; } = string.Empty;
+    public string[] Messages { get; init; } = [];
+
+    #endregion
+
+    #region Constructors
+
+    [JsonConstructor]
+    public Error() {}
+    
+    public Error(string code, params string[] messages)
+    {
+        Code = code;
+        Messages = messages;
+    }
+    
+    #endregion
 }

src/Riber.Infrastructure/DependencyInjection.cs

@@ -4,8 +4,6 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Serialization;
 using OpenTelemetry.Logs;
 using OpenTelemetry.Metrics;
 using OpenTelemetry.Resources;
@@ -52,7 +50,6 @@ public static void AddInfrastructure(this IServiceCollection services, IConfigur
         services.AddServices(configuration);
         services.AddAwsServices(configuration);
         services.AddBackgroundJobs(defaultConnection);
-        services.AddJsonConfiguration();
         services.AddHealthChecksConfiguration(defaultConnection);
         services.AddSchedulersAndJobs();
         services.AddTelemetry();
@@ -181,19 +178,6 @@ private static void AddBackgroundJobs(this IServiceCollection services, string d
             options.WaitForJobsToComplete = true);
     }
 
-    private static void AddJsonConfiguration(this IServiceCollection _)
-    {
-        JsonConvert.DefaultSettings = () => new JsonSerializerSettings
-        {
-            ReferenceLoopHandling = ReferenceLoopHandling.Ignore,
-            Formatting = Formatting.Indented,
-            NullValueHandling = NullValueHandling.Ignore,
-            DefaultValueHandling = DefaultValueHandling.Ignore,
-            ContractResolver = new CamelCasePropertyNamesContractResolver(),
-            TypeNameHandling = TypeNameHandling.Auto
-        };
-    }
-
     private static void AddTelemetry(this IServiceCollection services)
     {
         services.AddOpenTelemetry()