Skip to content

Questions! #2

Closed
Closed
@pranitsh

Description

@pranitsh

Hey,

I've been looking to contribute, and couldn't figure out a couple of things. I'd really appreciate you answering a couple of questions related to my future contribution so as to ensure that my future pull request can be merged.

  1. What is the idea behind topic and peer? And which relates to uuid (because I saw cases of both using uuid)? Admittedly, this question is probably on the dumber side since I have yet to spend a decent number of hours understanding editorjs. For my plan, I want to build an import and export toolkit for markdown, html, text, docx, github through the unified library. I'm currently testing using the injector for database via specifically creating random id, topic, and createdBy/lastEditedBy and inadvertendly random peers and topics. This approach is probably not correct, but using the Shell class seems even messier, since I want to add to the current file or specified files alongside sending a thousand CustomEvents seems like a decent way to crash. Any thoughts on how to approach this?
  2. What is the purpose of the form component in src/app/notebook/form? I had a couple of guesses, such as its relation to localhost:3000/form or the use of jsonforms (which I would appreciate you didn't depend on since it is old and the main dependency preventing updating Angular to 16), but I don't even know the purpose of these two parts either. I plan to remove this component in my pull request, if it is okay? Later, I plan to update to Angular 16.
  3. I've seen similar projects, including Standard Note, and believe the use of componentization is going to be soon necessary. You have a process worker, a shell process worker, a database with SQL (we really need SQL), and dozens of components related to coding. Would you be open to me fixing up the componentization? I would appreciate being added as a contributor in such a case.
  4. Lastly, I plan to use a devcontainer folder instead of .gitpod.yml, would that be okay?
  5. There is also many, many unnecessary // @ts-ignore. I plan to add a .eslintrc file and fix up the code quality. Would that be alright?

Thanks for answering my questions, and I hope my contributions are successful.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions