Suggestion for indent rule

[Avaq]

We recently started using add (21) (21) style call expressions at work, and I came up with the following indent rule to facilitate it:

{"indent": ["error", 2, {
  "ignoredNodes": ["CallExpression[callee.type='CallExpression']"]
}]}

The magic is in the ignoreNodes rule. It says that any CallExpression calling another CallExpression doesn't need to follow indentation rules.

There are many other directives that can be added to the indent rule options to further customize the rules, but they are not relevant to this example.

[davidchambers]

Excellent! Could you provide an example of “incorrectly” indented code that this change would permit?

[Avaq]

add (21)
    (21)

The second call expression has a "callee" which is also a call expression, therefore the indentation rule is ignored there.

[davidchambers]

Perfect. Would you like to submit a pull request?

[Avaq]

I don't mind doing it, but I don't have time for it now. I will definitely get to it some day, though. :)

However, seeing as we'll have to reach an agreement on the other directives: https://eslint.org/docs/rules/indent#options, and as you probably already have opinions on those, it might be faster for you to come up with the rules yourself. You can simply add the ignoredNodes thing from my suggestion to suppress the error that made you disable indent rules in the first place.

[davidchambers]

Sanctuary actually specifies a custom indent rule which contains several exceptions. If you remove an exception from the list then run npm run lint, you will see why the exception is necessary.

Do you still think this is worth undertaking, or is the solution too inelegant and potentially unreliable?