|
| 1 | +export const commentsData = [ |
| 2 | + // ---- Two Sum (Laith's review) ---- |
| 3 | + { |
| 4 | + id: 'comment_laith_two_sum_001', |
| 5 | + reviewId: 'review_laith_carter_two_sum_001', |
| 6 | + line: 2, |
| 7 | + content: 'Good call reaching for a hash map up front. Gets us O(n) instead of O(n^2).', |
| 8 | + reviewedAt: new Date('2026-04-13T15:08:00Z'), |
| 9 | + }, |
| 10 | + { |
| 11 | + id: 'comment_laith_two_sum_002', |
| 12 | + reviewId: 'review_laith_carter_two_sum_001', |
| 13 | + line: 6, |
| 14 | + content: 'Returning indices in insertion order is clean. Nice.', |
| 15 | + reviewedAt: new Date('2026-04-13T15:12:00Z'), |
| 16 | + }, |
| 17 | + { |
| 18 | + id: 'comment_laith_two_sum_003', |
| 19 | + reviewId: 'review_laith_carter_two_sum_001', |
| 20 | + line: 8, |
| 21 | + content: |
| 22 | + 'Trailing `return []` is defensive but unreachable given the prompt guarantees a solution. Minor nit.', |
| 23 | + reviewedAt: new Date('2026-04-13T15:18:00Z'), |
| 24 | + }, |
| 25 | + |
| 26 | + // ---- Two Sum (Brad's review) ---- |
| 27 | + { |
| 28 | + id: 'comment_brad_two_sum_001', |
| 29 | + reviewId: 'review_brad_carter_two_sum_001', |
| 30 | + line: 3, |
| 31 | + content: '`enumerate` over the loop is the right move.', |
| 32 | + reviewedAt: new Date('2026-04-13T16:32:00Z'), |
| 33 | + }, |
| 34 | + { |
| 35 | + id: 'comment_brad_two_sum_002', |
| 36 | + reviewId: 'review_brad_carter_two_sum_001', |
| 37 | + line: 7, |
| 38 | + content: |
| 39 | + 'Storing the index after the check avoids using the same element twice. Nicely handled.', |
| 40 | + reviewedAt: new Date('2026-04-13T16:35:00Z'), |
| 41 | + }, |
| 42 | + |
| 43 | + // ---- Reverse String (Laith's review) ---- |
| 44 | + { |
| 45 | + id: 'comment_laith_reverse_001', |
| 46 | + reviewId: 'review_laith_carter_reverse_string_001', |
| 47 | + line: 2, |
| 48 | + content: |
| 49 | + '`s.reverse()` mutates in place — correct, but then returning `s` is a bit redundant.', |
| 50 | + reviewedAt: new Date('2026-04-13T15:27:00Z'), |
| 51 | + }, |
| 52 | + { |
| 53 | + id: 'comment_laith_reverse_002', |
| 54 | + reviewId: 'review_laith_carter_reverse_string_001', |
| 55 | + line: 10, |
| 56 | + content: |
| 57 | + 'Since reverse_string mutates s in place, the return value is unused here. Worth pointing out in interview.', |
| 58 | + reviewedAt: new Date('2026-04-13T15:30:00Z'), |
| 59 | + }, |
| 60 | + |
| 61 | + // ---- Reverse String (Brad's review) ---- |
| 62 | + { |
| 63 | + id: 'comment_brad_reverse_001', |
| 64 | + reviewId: 'review_brad_carter_reverse_string_001', |
| 65 | + line: 2, |
| 66 | + content: 'In-place reverse satisfies the O(1) memory constraint. Good.', |
| 67 | + reviewedAt: new Date('2026-04-13T16:41:00Z'), |
| 68 | + }, |
| 69 | + |
| 70 | + // ---- Valid Palindrome (Laith's review) ---- |
| 71 | + { |
| 72 | + id: 'comment_laith_palindrome_001', |
| 73 | + reviewId: 'review_laith_carter_palindrome_001', |
| 74 | + line: 5, |
| 75 | + content: |
| 76 | + 'String concatenation in a loop is O(n^2) in Python. A list + join would be cleaner.', |
| 77 | + reviewedAt: new Date('2026-04-13T15:53:00Z'), |
| 78 | + }, |
| 79 | + { |
| 80 | + id: 'comment_laith_palindrome_002', |
| 81 | + reviewId: 'review_laith_carter_palindrome_001', |
| 82 | + line: 8, |
| 83 | + content: |
| 84 | + 'Bug: an empty string after stripping non-alphanumerics IS a palindrome per the prompt. Returning False here fails the " " test case.', |
| 85 | + reviewedAt: new Date('2026-04-13T15:57:00Z'), |
| 86 | + }, |
| 87 | + { |
| 88 | + id: 'comment_laith_palindrome_003', |
| 89 | + reviewId: 'review_laith_carter_palindrome_001', |
| 90 | + line: 9, |
| 91 | + content: |
| 92 | + 'Slice comparison is a clear approach. Two-pointer would avoid the extra allocation but is not required.', |
| 93 | + reviewedAt: new Date('2026-04-13T16:02:00Z'), |
| 94 | + }, |
| 95 | + |
| 96 | + // ---- Valid Palindrome (Brad's review) ---- |
| 97 | + { |
| 98 | + id: 'comment_brad_palindrome_001', |
| 99 | + reviewId: 'review_brad_carter_palindrome_001', |
| 100 | + line: 7, |
| 101 | + content: |
| 102 | + 'The empty-string guard inverts the expected behavior — see the failing test case.', |
| 103 | + reviewedAt: new Date('2026-04-13T16:52:00Z'), |
| 104 | + }, |
| 105 | + { |
| 106 | + id: 'comment_brad_palindrome_002', |
| 107 | + reviewId: 'review_brad_carter_palindrome_001', |
| 108 | + line: 15, |
| 109 | + content: |
| 110 | + '`readline` vs `read` should not matter for single-line input, but worth confirming with the candidate.', |
| 111 | + reviewedAt: new Date('2026-04-13T16:55:00Z'), |
| 112 | + }, |
| 113 | +]; |
0 commit comments