From ff848021281871450f70effad807a797df06bcec Mon Sep 17 00:00:00 2001 From: Ahmed Sheimy Date: Wed, 26 Oct 2022 23:49:31 +0400 Subject: [PATCH 1/3] Update OBD2.cpp this lib is not working with all car so we have to modify the can ID to send the CAN obd request correctrlly --- src/OBD2.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/OBD2.cpp b/src/OBD2.cpp index 8fd329c..62bed6e 100644 --- a/src/OBD2.cpp +++ b/src/OBD2.cpp @@ -709,7 +709,7 @@ int OBD2Class::clearAllStoredDTC() if (_useExtendedAddressing) { CAN.beginExtendedPacket(0x18db33f1, 8); } else { - CAN.beginPacket(0x7df, 8); + CAN.beginPacket(0x7e0, 8); } CAN.write(0x00); // number of additional bytes CAN.write(0x04); // Mode / Service 4, for clearing DTC @@ -736,7 +736,7 @@ int OBD2Class::pidRead(uint8_t mode, uint8_t pid, void* data, int length) if (_useExtendedAddressing) { CAN.beginExtendedPacket(0x18db33f1, 8); } else { - CAN.beginPacket(0x7df, 8); + CAN.beginPacket(0x7e0, 8); } CAN.write(0x02); // number of additional bytes CAN.write(mode); @@ -772,7 +772,7 @@ int OBD2Class::pidRead(uint8_t mode, uint8_t pid, void* data, int length) if (_useExtendedAddressing) { CAN.beginExtendedPacket(0x18db33f1, 8); } else { - CAN.beginPacket(0x7df, 8); + CAN.beginPacket(0x7e0, 8); } CAN.write(0x30); CAN.endPacket(); From a7ed2edfefb56660509bb0652bb18094a340d225 Mon Sep 17 00:00:00 2001 From: Ahmed Sheimy Date: Thu, 27 Oct 2022 08:54:05 +0400 Subject: [PATCH 2/3] Update OBD2.h add def for CAN_ID that can be changed if this one dos not work for your car --- src/OBD2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/OBD2.h b/src/OBD2.h index 0605763..26e4694 100644 --- a/src/OBD2.h +++ b/src/OBD2.h @@ -3,6 +3,7 @@ #ifndef OBD2_H #define OBD2_H +#define CAN_ID 0x7E0 enum { PIDS_SUPPORT_01_20 = 0x00, From 773d6840a6c6b588e9d71bfb92cc86eebfc0fd8e Mon Sep 17 00:00:00 2001 From: Ahmed Sheimy Date: Thu, 27 Oct 2022 08:55:12 +0400 Subject: [PATCH 3/3] Update OBD2.cpp --- src/OBD2.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/OBD2.cpp b/src/OBD2.cpp index 62bed6e..52ef999 100644 --- a/src/OBD2.cpp +++ b/src/OBD2.cpp @@ -709,7 +709,7 @@ int OBD2Class::clearAllStoredDTC() if (_useExtendedAddressing) { CAN.beginExtendedPacket(0x18db33f1, 8); } else { - CAN.beginPacket(0x7e0, 8); + CAN.beginPacket(CAN_ID, 8); } CAN.write(0x00); // number of additional bytes CAN.write(0x04); // Mode / Service 4, for clearing DTC @@ -736,7 +736,7 @@ int OBD2Class::pidRead(uint8_t mode, uint8_t pid, void* data, int length) if (_useExtendedAddressing) { CAN.beginExtendedPacket(0x18db33f1, 8); } else { - CAN.beginPacket(0x7e0, 8); + CAN.beginPacket(CAN_ID, 8); } CAN.write(0x02); // number of additional bytes CAN.write(mode); @@ -772,7 +772,7 @@ int OBD2Class::pidRead(uint8_t mode, uint8_t pid, void* data, int length) if (_useExtendedAddressing) { CAN.beginExtendedPacket(0x18db33f1, 8); } else { - CAN.beginPacket(0x7e0, 8); + CAN.beginPacket(CAN_ID, 8); } CAN.write(0x30); CAN.endPacket();