Several performance optimiziations

Author: whart222

Diff for: lib/coek/coek/api/parameter_assoc_array.cpp

@@ -36,8 +36,9 @@ void ParameterAssocArrayRepn::value(double value)
 {
     parameter_template.value(value);
     if (values.size() > 0) {
+        Expression e(value);
         for (auto& var : values)
-            var.value(value);
+            var.value(e);
     }
 }
 

Diff for: lib/coek/coek/api/variable_assoc_array.cpp

@@ -46,8 +46,9 @@ void VariableAssocArrayRepn::value(double value)
 {
     variable_template.value(value);
     if (values.size() > 0) {
+        coek::Expression e(value);
         for (auto& var : values)
-            var.value(value);
+            var.value(e);
     }
 }
 
@@ -64,8 +65,9 @@ void VariableAssocArrayRepn::lower(double value)
 {
     variable_template.lower(value);
     if (values.size() > 0) {
+        coek::Expression e(value);
         for (auto& var : values)
-            var.lower(value);
+            var.lower(e);
     }
 }
 
@@ -82,8 +84,9 @@ void VariableAssocArrayRepn::upper(double value)
 {
     variable_template.upper(value);
     if (values.size() > 0) {
+        coek::Expression e(value);
         for (auto& var : values)
-            var.upper(value);
+            var.upper(e);
     }
 }
 
@@ -100,26 +103,30 @@ void VariableAssocArrayRepn::bounds(double lb, double ub)
 {
     variable_template.bounds(lb, ub);
     if (values.size() > 0) {
+        coek::Expression lower(lb);
+        coek::Expression upper(ub);
         for (auto& var : values)
-            var.bounds(lb, ub);
+            var.bounds(lower,upper);
     }
 }
 
 void VariableAssocArrayRepn::bounds(const Expression& lb, double ub)
 {
     variable_template.bounds(lb, ub);
     if (values.size() > 0) {
+        coek::Expression upper(ub);
         for (auto& var : values)
-            var.bounds(lb, ub);
+            var.bounds(lb,upper);
     }
 }
 
 void VariableAssocArrayRepn::bounds(double lb, const Expression& ub)
 {
     variable_template.bounds(lb, ub);
     if (values.size() > 0) {
+        coek::Expression lower(lb);
         for (auto& var : values)
-            var.bounds(lb, ub);
+            var.bounds(lower,ub);
     }
 }