Skip to content

ExperimentGraphDecorable uses ambiguous key to deconflict entries #122

@mitchnegus

Description

@mitchnegus

When the ExperimentGraphDecorable looks for decorator conflicts, it uses the cached list of attributes corresponding to the key matching the decorator class's name.

For example, let's say two MCs define a decorator with the same name: perhaps I have a decorator my_mc_package.CoolVM and you have a decorator your_mc_package.CoolVM. Right now, the deconfliction process will look to see if CoolVM has cached entries, and for your_mc_package.CoolVM it will find the dictionary value for CoolVM corresponding to my_mc_package.CoolVM. FIREWHEEL will then error with a message that the second decorator (CoolVM) has conflicts and must be resolved, but with an attribute matching the first decorator.... of course, since the error message just gives you the duplicated name (CoolVM), it is not apparent to a user that the conflict is actually with their second decorator, and not the first CoolVM.

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions