-
Notifications
You must be signed in to change notification settings - Fork 58
Description
The find_germs function accepts a few runtime modes: {'all-Jac', 'single-Jac', 'compactEVD'}. Compact EVD runs orders of magnitudes faster than the other modes for 2-qubit germ selection. I suggest it be made the default mode, replacing the current default of all-Jac.
A counter-argument to this suggestion is that all-Jac can run with a wider range of settings than compactEVD. My counter-counter argument to that is that the defaults for other kwargs means that users can already set mode='compactEVD' without having to think beyond that. If a user provides a keyword argument that conflicts with compactEVD then it'd reasonable for us to just raise an error saying "you have to change the mode to something other than compactEVD if you want to use kwarg {k}={v}."