MISC: Address coverity findings

Author: gsjaardema

packages/seacas/applications/nem_spread/pe_input.C

@@ -1,5 +1,5 @@
 /*
- * Copyright(C) 1999-2020, 2023 National Technology & Engineering Solutions
+ * Copyright(C) 1999-2020, 2023, 2025 National Technology & Engineering Solutions
  * of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
  * NTESS, the U.S. Government retains certain rights in this software.
  *
@@ -434,8 +434,7 @@ int read_pexoII_info(NemSpread<T, INT> &spreader, const char *filename)
             cptr++;
 
             /* allocate memory for to hold the values */
-            PIO_Info.Dsk_List = reinterpret_cast<int *>(
-                array_alloc(__FILE__, __LINE__, 1, PIO_Info.Dsk_List_Cnt, sizeof(int)));
+            PIO_Info.Dsk_List.resize(PIO_Info.Dsk_List_Cnt);
             for (i = 0; i < (PIO_Info.Dsk_List_Cnt - 1); i++) {
               sscanf(cptr, "%d", &(PIO_Info.Dsk_List[i]));
               cptr = strtok(nullptr, ", \t;");

packages/seacas/applications/nem_spread/ps_pario_const.h

@@ -1,5 +1,5 @@
 /*
- * Copyright(C) 1999-2020, 2022, 2023, 2024 National Technology & Engineering Solutions
+ * Copyright(C) 1999-2020, 2022, 2023, 2024, 2025 National Technology & Engineering Solutions
  * of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
  * NTESS, the U.S. Government retains certain rights in this software.
  *
@@ -25,7 +25,7 @@ struct Parallel_IO
 {
   int Dsk_List_Cnt{};
 
-  int  *Dsk_List{nullptr};
+  std::vector<int>  Dsk_List{};
   int **RDsk_List{nullptr};
 
   int Num_Dsk_Ctrlrs{};  /* The number of disk controllers.     */

packages/seacas/libraries/aprepro_lib/apr_exodus.cc

@@ -38,15 +38,15 @@ namespace {
     }
   }
 
-  void add_name(int exoid, ex_entity_type ent_type, int64_t id, char *name, std::string &names)
+  void add_name(int exoid, ex_entity_type ent_type, int64_t id, std::vector<char> &name, std::string &names)
   {
     std::string str_name;
-    ex_get_name(exoid, ent_type, id, name);
+    ex_get_name(exoid, ent_type, id, name.data());
     if (name[0] == '\0') {
       str_name = entity_type_name(ent_type) + std::to_string(id);
     }
     else {
-      str_name = name;
+      str_name = name.data();
     }
 
     if (names.length() > 0) {
@@ -313,7 +313,7 @@ namespace SEAMS {
     // -- 'ex_sideset_info'
     int max_name_length = ex_inquire_int(exoid, EX_INQ_DB_MAX_USED_NAME_LENGTH);
     ex_set_max_name_length(exoid, max_name_length);
-    char       *name = new char[max_name_length + 1];
+    std::vector<char> name(max_name_length + 1);
     std::string str_name;
 
     if (info.num_elem_blk > 0) {
@@ -366,7 +366,7 @@ namespace SEAMS {
       for (int64_t i = 0; i < info.num_assembly; i++) {
         ex_assembly assembly;
         assembly.id          = ids[i];
-        assembly.name        = new char[max_name_length + 1];
+        assembly.name        = name.data();
         assembly.entity_list = nullptr;
 
         ex_get_assembly(exoid, &assembly);
@@ -460,11 +460,11 @@ namespace SEAMS {
     if (num_global > 0) {
       std::string names;
       for (int i = 0; i < num_global; i++) {
-        ex_get_variable_name(exoid, EX_GLOBAL, i + 1, name);
+        ex_get_variable_name(exoid, EX_GLOBAL, i + 1, name.data());
         if (i > 0) {
           names += ",";
         }
-        names += name;
+        names += name.data();
       }
       aprepro->add_variable("ex_global_var_names", names);
 
@@ -480,7 +480,6 @@ namespace SEAMS {
       aprepro->add_variable("ex_global_var_value", glo_array_data);
     }
 
-    delete[] name;
     ex_close(exoid);
     return "";
   }