Add assertion for sort loop

Author: gsjaardema

packages/seacas/applications/nem_slice/elb_util.C

@@ -1,5 +1,5 @@
 /*
- * Copyright(C) 1999-2024 National Technology & Engineering Solutions
+ * Copyright(C) 1999-2025 National Technology & Engineering Solutions
  * of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
  * NTESS, the U.S. Government retains certain rights in this software.
  *
@@ -266,6 +266,7 @@ namespace {
     for (size_t i = 1; i < N; i++) {
       INT tmp = v[i];
       for (j = i; tmp < v[j - 1]; j--) {
+	assert(j >= 1);
         v[j] = v[j - 1];
       }
       v[j] = tmp;
@@ -633,6 +634,7 @@ namespace {
       for (j = i; is_less_than4(small_val1, small_val2, small_val3, small_val4, v1[j - 1],
                                 v2[j - 1], v3[j - 1], v4[j - 1]);
            j--) {
+	assert(j >= 1);
         v1[j] = v1[j - 1];
         v2[j] = v2[j - 1];
         v3[j] = v3[j - 1];
@@ -748,6 +750,7 @@ namespace {
       INT    small_val2 = v2[i];
       size_t j;
       for (j = i; is_less_than2(small_val1, small_val2, v1[j - 1], v2[j - 1]); j--) {
+	assert(j >= 1);
         v1[j] = v1[j - 1];
         v2[j] = v2[j - 1];
       }

packages/seacas/applications/nem_spread/sort_utils.C

@@ -1,5 +1,5 @@
 /*
- * Copyright(C) 1999-2023 National Technology & Engineering Solutions
+ * Copyright(C) 1999-2023, 2025 National Technology & Engineering Solutions
  * of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
  * NTESS, the U.S. Government retains certain rights in this software.
  *
@@ -107,6 +107,7 @@ namespace {
       INT    tmp = iv[i];
       size_t j;
       for (j = i; v[tmp] < v[iv[j - 1]]; j--) {
+	assert(j >= 1);
         iv[j] = iv[j - 1];
       }
       iv[j] = tmp;
@@ -188,6 +189,7 @@ namespace {
       INT    tmp = v[i];
       size_t j;
       for (j = i; tmp < v[j - 1]; j--) {
+	assert(j >= 1);
         v[j] = v[j - 1];
       }
       v[j] = tmp;

packages/seacas/libraries/suplib_cpp/iqsort.C

@@ -1,9 +1,10 @@
-// Copyright(C) 1999-2020, 2023, 2024 National Technology & Engineering Solutions
+// Copyright(C) 1999-2020, 2023, 2024, 2025 National Technology & Engineering Solutions
 // of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
 // NTESS, the U.S. Government retains certain rights in this software.
 //
 // See packages/seacas/LICENSE for details
 #include "iqsort.h"
+#include <assert.h>
 #include <cstdint>
 #include <fmt/ostream.h>
 
@@ -147,6 +148,7 @@ namespace {
     for (size_t i = 1; i < N; i++) {
       INT tmp = iv[i];
       for (j = i; v[tmp] < v[iv[j - 1]]; j--) {
+	assert(j >= 1);
         iv[j] = iv[j - 1];
       }
       iv[j] = tmp;