Minor fixes (#639)

fix tests to be robust to non-breaking api changes.
Also, change binary asset check so it is not recursive.
This avoids an infinite loop in some environments.

Author: jnhealy2

manager/manager_cmds/distribution.py

@@ -393,11 +393,10 @@ def _write(self, data):
 
 
 def is_installed(spec):
-    status = True
-    for dependency in spec.dependencies(deptype=("link", "run")):
-        status = is_installed(dependency)
+    deps = list(spec.dependencies(deptype=("link", "run")))
     bad_statuses = [spack.spec.InstallStatus.absent, spack.spec.InstallStatus.missing]
-    return status and spec.install_status() not in bad_statuses
+    dep_status = [x.install_status() not in bad_statuses for x in deps]
+    return all(dep_status) and spec.install_status() not in bad_statuses
 
 
 def correct_mirror_args(env, args):

tests/test_distribution.py

@@ -715,7 +715,7 @@ def test_DistributionPackager_configure_source_mirror_create_mirror_called_corre
 
     def mirror_for_specs(*args, **kwargs):
         assert len(args) == 0
-        assert len(kwargs) == len(valid_params)
+        assert len(kwargs) <= len(valid_params)
         for kwarg in kwargs:
             assert kwarg in valid_params