Skip to content

Drop the origin of some section types being automatically detected. #210

Description

@amoodie

Drop the origin of some section types being automagically detected. This "feature" requires variables named L0, CTR, N0, and the like in the metadata at various points in the code (mostly in Mask and Section instantiation, I think).

from #203

Proposal:

  • Remove all automatic detection of geometry based on metadata.
  • Option 1: user could specify attributes of the Cube that are empty by default, but are used throughout the code if they are present.
  • Option 2: all geometry parameters need to be passed explicitly during Section and Mask instantiation.

I think option 2 is clearer and offers the greatest flexibility while minimizing the code to maintain. The downside is more typing, which makes the package "appear less useful".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions