Skip to content

Commit 5f305be

Browse files
committed
Set CI performance budget to 70 and clean up configs.
Added a `ci.budget` property with a value of 70 to both mobile and desktop configs. Removed redundant `--budget 30` flags from the GitHub workflow and improved general readability by cleaning up comments and unused settings. This ensures consistency and simplifies configuration management.
1 parent 51128a6 commit 5f305be

3 files changed

Lines changed: 29 additions & 22 deletions

File tree

.github/workflows/unlighouse.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ jobs:
3636
unlighthouse-ci \
3737
--site http://localhost:4173 \
3838
--config-file mobile-v1.config.ts
39-
--budget 30 \
4039
--reporter lighthouseServer \
4140
--lhci-host https://lhci-server-crimson-bush-1151.fly.dev \
4241
--lhci-build-token ${{ secrets.LHCI_BUILD_TOKEN }}
@@ -46,7 +45,6 @@ jobs:
4645
unlighthouse-ci \
4746
--site http://localhost:4173 \
4847
--config-file desktop-v1.config.ts
49-
--budget 30 \
5048
--reporter lighthouseServer \
5149
--lhci-host https://lhci-server-crimson-bush-1151.fly.dev \
5250
--lhci-build-token ${{ secrets.LHCI_BUILD_TOKEN }}

desktop-v1.config.ts

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
// This is the default that always gets used unless a different config file is specified
22
export default {
33

4+
// Maximum acceptable performance budget score for CI checks
5+
ci: {
6+
budget: 70
7+
},
8+
49
// // Increase accuracy by only allowing 1 page to be scanned at a time
510
// puppeteerClusterOptions: {
611
// // only run 1 worker at a time
@@ -19,15 +24,15 @@ export default {
1924
throttle: false,
2025
// //dynamicSampling: false, // or any number, default is 5
2126

22-
// // exclude specific routes
23-
// // exclude: [
24-
// // '/.*?pdf',
25-
// // '.*/amp',
26-
// // 'en-*',
27-
// // ],
27+
// // exclude specific routes
28+
// // exclude: [
29+
// // '/.*?pdf',
30+
// // '.*/amp',
31+
// // 'en-*',
32+
// // ],
2833

29-
// // run lighthouse for each URL 3 times
30-
samples: 1,
34+
// // run lighthouse for each URL 3 times
35+
// // samples: 3,
3136
},
3237

3338
////////////////////////////////////////////////////////////////////////////

mobile-v1.config.ts

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
// This is the default that always gets used unless a different config file is specified
22
export default {
33

4+
// Maximum acceptable performance budget score for CI checks
5+
ci: {
6+
budget: 70
7+
},
8+
49
// // Increase accuracy by only allowing 1 page to be scanned at a time
510
// puppeteerClusterOptions: {
611
// // only run 1 worker at a time
@@ -36,18 +41,18 @@ export default {
3641
////////////////////////////////////////////////////////////////////////////
3742
scanner: {
3843
device: 'mobile',
39-
throttle: true,
44+
throttle: true
4045

41-
// exclude specific routes
42-
// exclude: [
43-
// '/.*?pdf',
44-
// '.*/amp',
45-
// 'en-*',
46-
// ],
46+
// // exclude specific routes
47+
// // exclude: [
48+
// // '/.*?pdf',
49+
// // '.*/amp',
50+
// // 'en-*',
51+
// // ],
4752

48-
// run lighthouse for each URL 3 times
49-
samples: 1,
50-
},
53+
// // run lighthouse for each URL 3 times
54+
// // samples: 3,
55+
}
5156

5257
////////////////////////////////////////////////////////////////////////////
5358
// Emulate mobile with devtools settings:
@@ -72,6 +77,5 @@ export default {
7277
// throttlingMethod: 'devtools',
7378
// },
7479

75-
7680
// debug: true,
77-
}
81+
};

0 commit comments

Comments
 (0)