Conversation
|
|
Hi @DLBPointon, will take a look in depth tomorrow but just to double check - do the cram and the assembly channels share a meta? This is needed in order to ensure the joins within work. |
|
This is very strange, I don't understand what is happening. It looks like nothing goes through that |
|
I found the problem. I fixed it so that it returns a channel instead, and now mapping runs. You could alteratively revert that change and do: if you prefer. |
Absolute legend, thanks a ton Jim. Now onto adding |
prototaxites
left a comment
There was a problem hiding this comment.
Couple of implementation thoughts!
subworkflows/local/utils_nfcore_curationpretext_pipeline/main.nf
Outdated
Show resolved
Hide resolved
prototaxites
left a comment
There was a problem hiding this comment.
Looks good to me, one last comment about documentation
This reverts commit d35429f.
|
Somhow managed to poison the PR No matter what, I can't get it into a usable state. Once the branch is switched to, then it is poisoned and useless. Mind boggling issue. Instead I spent saturday morning re-writting the PR before the family got up, otherwise I would have thought about it all weekend. new PR is: #136 |

#130 - FOFN or FILE input
#129 - Update to use Jim's Module
@prototaxites - Can you have a look at the implementation of your hic mapping subworkflow into curationpretext please?
I've replaced the current method and am using the below to test (otherwise it will die as i havn't replaced the pretext mapper bits yet:
The test data is in the above dir. Essentially, processes are occasionally getting past here:
But no further.
Input cram channel to the subworkflow is:
Pipeline will freeze like:
Then dies with no error:
.nextflow.log shows nothing, presumably I'm passing in a dogey channel, but everything looks fine to me.
Thanks
Edit: This can wait till Monday so feel free to ignore!