Skip to content

Commit 670267f

Browse files
committed
Update params and changelog
1 parent c3e1b9d commit 670267f

File tree

15 files changed

+412
-56
lines changed

15 files changed

+412
-56
lines changed

.github/workflows/nf-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ jobs:
5050
NFT_VER: ${{ env.NFT_VER }}
5151
with:
5252
max_shards: 7
53+
tag: "githubci"
5354

5455
- name: debug
5556
run: |

CHANGELOG.md

Lines changed: 54 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,60 @@
33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6-
## [1.4.4] - Ancient Hippaforalkus (H1) - [2025-XX-XX]
6+
7+
## [1.4.6] - Ancient Hippaforalkus (H5) - [2026-03-XX]
8+
9+
Our 13th release for sanger-tol/treeval.
10+
11+
### Enhancements & Fixes
12+
- Update to pretext map, adds option to generate Ultra HiRes map.
13+
- Changes to confirm with nf-core strict syntax.
14+
15+
### Parameters
16+
| Old Parameter | New Parameter |
17+
| ------------- | ---------------- |
18+
| - | --run_ultra |
19+
20+
21+
### Software dependencies
22+
| Module | Old Version | New Versions |
23+
| -------------------------------------- | --------------------- | ---------------------------------- |
24+
| GET_LARGEST_SCAFFOLD (coreutils) | 9.1 | REMOVED |
25+
| busco/busco | 5.7.1 | 6.0.0 |
26+
| bwamem2/index (bwa-mem2) | 2.2.1 | 2.3+htslib=1.22.1+samtools=1.22.1 |
27+
| cat/cat (pigz) | 2.3.4 | 2.8 |
28+
| cooler/cload (cooler) | 0.9.2 | 0.10.4 |
29+
| cooler/zoomify (cooler) | 0.9.2 | 0.10.4+numpy=1.26.4 |
30+
| custom/dumpsoftwareversions | multiqc=1.20 | REMOVED |
31+
| custom/getchromsizes (htslib+samtools) | 1.21+1.22.1 | REMOVED |
32+
| fastk/fastk | 1.0.2 | 1.2 |
33+
| gnu/sort (coreutils) | 9.3 | coreutils=9.5 |
34+
| juicertools | | juicertools=2.20.00,openjdk=23.0.2 |
35+
| merquryfk/merquryfk | fastk=1.0.2 | 1.2 |
36+
| minimap2/align (minimap2+samtools) | 2.28+1.20+htslib=1.20 | 2.29+1.21 |
37+
| minimap2/index (minimap2) | 2.28 | 2.29 |
38+
| pretextmap (pretextmap+samtools) | 0.1.9+1.17 | 0.2.4+1.23+htslib=1.23 |
39+
| pretextsnapshot | 0.0.4 | 0.0.7 |
40+
| samtools/faidx (htslib+samtools) | 1.21+1.21 | 1.22.1+1.22.1 |
41+
| samtools/index (htslib+samtools) | 1.21+1.21 | REMOVED |
42+
| samtools/markdup (htslib+samtools) | 1.21+1.21 | 1.22.1+1.22.1 |
43+
| samtools/merge (htslib+samtools) | 1.21+1.21 | 1.22.1+1.22.1 |
44+
| samtools/sort (htslib+samtools) | 1.21+1.21 | REMOVED |
45+
| samtools/view (htslib+samtools) | 1.21+1.21 | REMOVED |
46+
| tabix/bgziptabix | 1.20+tabix=1.11 | 1.21 |
47+
| windowmasker/mkcounts (blast) | 2.15.0 | 2.17.0 |
48+
| windowmasker/ustat (blast) | 2.15.0 | 2.17.0 |
49+
| yahs | 1.2a.2 | 1.2.2
50+
51+
## [1.4.5] - Ancient Hippaforalkus (H5) - [2025-11-24]
52+
53+
Our 12th release for sanger-tol/treeval.
54+
55+
### Enhancements & Fixes
56+
- Bug fix, pretext files weren't being output due to the use of a closure rather than a list in modules.config.
57+
- Updated to BEDTOOLS INTERSECT resources
58+
59+
## [1.4.4] - Ancient Hippaforalkus (H4) - [2025-11-17]
760

861
Our 11th release for sanger-tol/treeval.
962

conf/test.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
process {
1818
resourceLimits = [
1919
cpus: 4,
20-
memory: '40.GB', // required for pretext map ultra res test
20+
memory: '10.GB', // required for pretext map ultra res test
2121
time: '1.h'
2222
]
2323
}

conf/test_full.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ process {
1919
resourceLimits = [
2020
cpus: 4,
2121
memory: '40.GB', // required for pretext map ultra res test
22-
time: '1.h'
22+
time: '2.h'
2323
]
2424
}
2525

docs/output.md

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ The pipeline is built using [Nextflow](https://www.nextflow.io/) and processes d
2222
- [synteny](#synteny) - Generates syntenic alignments between the input and other high quality genomes.
2323
- [busco-analysis](#busco-analysis) - Uses BUSCO to identify ancestral elements. Also use to identify ancestral Lepidopteran genes (merian units).
2424
- [kmer](#kmer) - Counts k-mer and generates a copy number spectra plot.
25-
- [kmer coverage](#kmer-coverage) - Counts k-mer (or uses existing k-mer profile) and produces k-mer coverage.
2625
- [pretext-ingestion](#pretext-ingestion) - Ingests accessory files into the pretext file.
2726

2827
- [pipeline-information](#pipeline-information) - Report metrics generated during the workflow execution
@@ -222,20 +221,6 @@ This subworkflow performs a k-mer count using [FASTK_FASTK](https://nf-co.re/mod
222221

223222
![Kmer Workflow](https://raw.githubusercontent.com/sanger-tol/treeval/main/docs/images/v1-1-0/treeval_1_1_0_kmer.png)
224223

225-
## kmer coverage
226-
227-
This subworkflow performs a k-mer count using [FASTK_FASTK](https://nf-co.re/modules/fastk_fastk) (or uses an already existing k-mer profile) then passes the results to FKUTILS_FKPROF to produces k-mer coverage track.
228-
229-
<details markdown="1">
230-
<summary>Output files</summary>
231-
232-
- `hic_files/`
233-
- `*_{kmer_size}_.bw`: .png file of copy number k-mer spectra.
234-
235-
</details>
236-
237-
![Kmer coverage Workflow](https://raw.githubusercontent.com/sanger-tol/treeval/main/docs/images/v1-1-0/treeval_1_1_0_kmer_coverage.png)
238-
239224
## Full Workflow diagram
240225

241226
The full pipeline diagram is very large, with the pipeline consisting of over 100 processes.

docs/usage.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,8 +417,6 @@ find v5/data -name "*.tar.gz" | parallel "cd {//}; tar -xzf {/}"
417417
- Uses BUSCO to identify ancestral elements. Also use to identify ancestral Lepidopteran genes (merian units).
418418
- `KMER`
419419
- Generating kmer graphs of the assembly.
420-
- `KMER_READ_COVERAGE`
421-
- Generating read coverage using kmers.
422420
423421
</details>
424422

main.nf

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,7 @@ workflow {
6565
PIPELINE_INITIALISATION.out.lineagespath,
6666
PIPELINE_INITIALISATION.out.binfile,
6767
PIPELINE_INITIALISATION.out.juicer,
68-
PIPELINE_INITIALISATION.out.mode,
69-
PIPELINE_INITIALISATION.out.split_telomere,
70-
PIPELINE_INITIALISATION.out.run_hires,
71-
PIPELINE_INITIALISATION.out.run_ultra
68+
PIPELINE_INITIALISATION.out.mode
7269
)
7370

7471
//

subworkflows/local/hic_mapping/main.nf

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ workflow HIC_MAPPING {
4343
workflow_setting // string: Run mode (FULL, RAPID, RAPID_TOL, etc.)
4444
binfile // boolean: Generate bin file using YAHS
4545
juicer // boolean: Generate .hic file using Juicer
46-
split_telomere // boolean: Split telomere signal into 5p and 3p
47-
run_hires // boolean: Generate high resolution pretext maps
48-
run_ultra // boolean: Generate high resolution pretext maps
4946

5047
main:
5148
ch_versions = channel.empty()
@@ -208,11 +205,11 @@ workflow HIC_MAPPING {
208205
coverage_file.map{ _meta, covfile -> covfile },
209206
telo_file,
210207
repeat_density_file.map{ _meta, rdfile -> rdfile },
211-
split_telomere
208+
params.split_telomere
212209
)
213210
ch_versions = ch_versions.mix( PRETEXT_INGEST_SNDRD.out.versions )
214211

215-
if (run_hires) {
212+
if (params.run_hires) {
216213
//
217214
// MODULE: GENERATE PRETEXT MAP FROM MAPPED BAM FOR HIGH RES
218215
//
@@ -243,7 +240,7 @@ workflow HIC_MAPPING {
243240
hires_pretext = channel.empty()
244241
}
245242

246-
if (run_ultra) {
243+
if (params.run_ultra) {
247244
//
248245
// MODULE: GENERATE PRETEXT MAP FROM MAPPED BAM FOR HIGH RES
249246
//

subworkflows/local/utils_nfcore_treeval_pipeline/main.nf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ workflow PIPELINE_INITIALISATION {
3737
mode // string: Run mode, default FULL, alternatives: JBROWSE, RAPID, RAPID_TOL, FULL_COMBINED
3838
binfile // boolean: Generate bin file using YAHS
3939
juicer // boolean: Generate .hic file using Juicer
40-
split_telomere // boolean: Split telomere scaffolds into 3p and 5p
41-
run_hires // boolean: Generate high resolution pretext maps
42-
run_ultra // boolean: Generate ultra high resolution pretext maps
4340
help // boolean: Display help message and exit
4441
help_full // boolean: Show the full help message
4542
show_hidden // boolean: Show hidden parameters in the help message
@@ -110,9 +107,6 @@ workflow PIPELINE_INITIALISATION {
110107
binfile = binfile
111108
juicer = juicer
112109
mode = mode
113-
split_telomere = split_telomere
114-
run_hires = run_hires
115-
run_ultra = run_ultra
116110
versions = ch_versions
117111
}
118112

tests/main.nf.test

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
nextflow_pipeline {
2+
3+
name "Test TreeVal Full pipeline w/o hi res and ultra res pretext maps"
4+
script "../main.nf"
5+
tag "pipeline"
6+
tag "full"
7+
tag "githubci"
8+
9+
config '../conf/test.config'
10+
11+
test("Run w/o hi res and ultra res pretext maps") {
12+
13+
setup {
14+
println "Downloading BUSCO test data..."
15+
def busco_test_url = "https://tolit.cog.sanger.ac.uk/test-data/resources/treeval/TreeValTinyData/busco.tar.gz"
16+
def busco_test_command = ['bash', '-c', "curl -L --retry 5 --retry-delay 10 ${busco_test_url} | tar xzf - -C ${launchDir}"]
17+
def busco_test_proc = busco_test_command.execute()
18+
busco_test_proc.waitFor()
19+
20+
if (busco_test_proc.exitValue() != 0) {
21+
throw new RuntimeException("Error - failed to download busco data: ${busco_test_proc.err.text}")
22+
}
23+
}
24+
25+
when {
26+
params {
27+
outdir = "$outputDir"
28+
}
29+
}
30+
31+
then {
32+
// stable_name: All files + folders in ${params.outdir}/ with a stable name
33+
def stable_name = getAllFilesFromDir(params.outdir, relative: true, includeDir: true, ignore: ['pipeline_info/*.{html,json,txt}','hic_files/*.ktab*'])
34+
// stable_path: All files in ${params.outdir}/ with stable content
35+
def stable_path = getAllFilesFromDir(params.outdir, ignoreFile: 'tests/.nftignore')
36+
37+
assertAll(
38+
{ assert workflow.success},
39+
{ assert snapshot(
40+
// Number of successful tasks
41+
workflow.trace.succeeded().size(),
42+
43+
// pipeline versions.yml file for multiqc from which Nextflow version is removed because we test pipelines on multiple Nextflow versions
44+
removeNextflowVersion("$outputDir/pipeline_info/treeval_software_versions.yml"),
45+
46+
// All stable path name, with a relative path
47+
stable_name,
48+
49+
// All files with stable contents
50+
stable_path
51+
52+
).match() }
53+
)
54+
}
55+
cleanup {
56+
new File("${launchDir}/busco")
57+
}
58+
}
59+
}

0 commit comments

Comments
 (0)