Skip to content

Await assembler task cancellations to prevent pending task error when program exits#3157

Draft
ChihweiLHBird wants to merge 1 commit into
sanic-org:mainfrom
ChihweiLHBird:zhiwei/ws-cancel-fix
Draft

Await assembler task cancellations to prevent pending task error when program exits#3157
ChihweiLHBird wants to merge 1 commit into
sanic-org:mainfrom
ChihweiLHBird:zhiwei/ws-cancel-fix

Conversation

@ChihweiLHBird

Copy link
Copy Markdown
Member

Resolve #2564

… program exits

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
@codecov

codecov Bot commented Apr 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.720%. Comparing base (785d77f) to head (780d351).

Files with missing lines Patch % Lines
sanic/server/websockets/impl.py 55.555% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main     #3157       +/-   ##
=============================================
- Coverage   87.793%   87.720%   -0.073%     
=============================================
  Files          105       105               
  Lines         8143      8152        +9     
  Branches      1290      1290               
=============================================
+ Hits          7149      7151        +2     
- Misses         687       695        +8     
+ Partials       307       306        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task was destroyed but it is pending! WebsocketFrameAssembler.get()

1 participant