feat(deploy): list problems with fixes and surface warnings in the dry-run report

When a dry run can't deploy, the report now groups the failing checks under
"Problems to fix" — each with its solution — and lists warnings in their own
section, instead of a flat mixed list.

Author: gu-stav

packages/@sanity/cli/src/actions/deploy/__tests__/deploymentPlan.test.ts

@@ -73,14 +73,38 @@ describe('renderDeploymentPlan', () => {
     expect(text).toContain('dist/index.html (1.50 MB)')
   })
 
-  test('reports non-deployable when a check failed', () => {
-    renderDeploymentPlan(studioPlan([{message: 'Missing project id', status: 'fail'}]), output)
+  test('lists problems with their solutions when a check failed', () => {
+    renderDeploymentPlan(
+      studioPlan([
+        {message: 'No project ID configured', solution: 'Add `api.projectId`', status: 'fail'},
+      ]),
+      output,
+    )
 
     const text = lines.join('\n')
-    expect(text).toContain('cannot be deployed')
+    expect(text).toContain("This studio can't be deployed.")
+    expect(text).toContain('Problems to fix:')
+    expect(text).toContain('No project ID configured')
+    expect(text).toContain('→ Add `api.projectId`')
     expect(text).toContain('Files to deploy (0.00 MB):')
   })
 
+  test('surfaces warnings in their own section', () => {
+    renderDeploymentPlan(
+      studioPlan([
+        {message: 'Project: p1', status: 'pass'},
+        {message: 'The `autoUpdates` config has moved', solution: 'Move it', status: 'warn'},
+      ]),
+      output,
+    )
+
+    const text = lines.join('\n')
+    expect(text).toContain('This studio can be deployed.')
+    expect(text).toContain('Warnings:')
+    expect(text).toContain('The `autoUpdates` config has moved')
+    expect(text).toContain('→ Move it')
+  })
+
   test('labels a core app deploy as an application', () => {
     renderDeploymentPlan({checks: [], files: [], type: 'coreApp'}, output)
 

packages/@sanity/cli/src/actions/deploy/deploymentPlan.ts

@@ -67,27 +67,46 @@ export async function listDeploymentFiles(
 /** Renders a deployment plan as a minimal, human-readable report. */
 export function renderDeploymentPlan(plan: DeploymentPlan, output: Output): void {
   const label = plan.type === 'coreApp' ? 'application' : 'studio'
-  const deployable = plan.checks.every((check) => check.status !== 'fail')
+  const problems = plan.checks.filter((check) => check.status === 'fail')
+  const warnings = plan.checks.filter((check) => check.status === 'warn')
   const totalBytes = plan.files.reduce((sum, file) => sum + file.size, 0)
 
   output.log('\nDry run — no changes made.\n')
 
+  // Checks that passed or were skipped; problems and warnings get their own
+  // sections below so each fix sits next to the thing it fixes.
   for (const check of plan.checks) {
-    output.log(`  ${statusIcon(check.status)} ${check.message}`)
+    if (check.status === 'pass' || check.status === 'skip') {
+      output.log(`  ${statusIcon(check.status)} ${check.message}`)
+    }
   }
 
   output.log(
-    deployable
+    problems.length === 0
       ? styleText('green', `\nThis ${label} can be deployed.`)
-      : styleText('red', `\nThis ${label} cannot be deployed — resolve the issues above.`),
+      : styleText('red', `\nThis ${label} can't be deployed.`),
   )
 
+  renderIssues(output, 'Problems to fix:', problems)
+  renderIssues(output, 'Warnings:', warnings)
+
   output.log(`\nFiles to deploy (${formatMB(totalBytes)}):`)
   for (const file of plan.files) {
     output.log(`  ${file.path} (${formatMB(file.size)})`)
   }
 }
 
+/** Renders a titled list of checks, each with its fix indented beneath. */
+function renderIssues(output: Output, title: string, checks: DeployCheck[]): void {
+  if (checks.length === 0) return
+
+  output.log(`\n${title}`)
+  for (const check of checks) {
+    output.log(`  ${statusIcon(check.status)} ${check.message}`)
+    if (check.solution) output.log(`      → ${check.solution}`)
+  }
+}
+
 /** Bytes as megabytes with two decimals, e.g. `1.50 MB`. */
 function formatMB(bytes: number): string {
   return `${(bytes / 1024 / 1024).toFixed(2)} MB`