chore(test): removing duplicate tests that already exist as unit tests

Author: filmaj

packages/@sanity/cli/test/integration/commands/mcp/configure.test.ts

@@ -82,31 +82,6 @@ function mockMCPTokenCreation(token: string): void {
 // Helpers for table-driven per-editor tests
 // ---------------------------------------------------------------------------
 
-interface EditorTestCase {
-  /** How to make this editor detectable */
-  detect: {
-    /** CLI commands that should succeed (e.g. ['codex', 'claude']) */
-    cliCommands?: string[]
-    /** Env vars to set for this test */
-    env?: Record<string, string>
-    /** existsSync predicate — receives the path string */
-    existsSync?: (p: string) => boolean
-    /** Platform to override via Object.defineProperty */
-    overridePlatform?: NodeJS.Platform
-  }
-  /** Substring the written config path must contain */
-  expectedConfigPath: string
-  /** Editor name as it appears in EDITOR_CONFIGS */
-  name: string
-
-  /** Extra substrings the written content must contain (beyond the token) */
-  expectedContentChecks?: string[]
-  /** If true, this editor uses OAuth natively and does not need an embedded API token */
-  oauthOnly?: boolean
-  /** Only run on this platform (skipped otherwise) */
-  platform?: NodeJS.Platform
-}
-
 const EXECA_SUCCESS = {
   command: 'test --version',
   exitCode: 0,
@@ -118,294 +93,6 @@ const EXECA_SUCCESS = {
   timedOut: false,
 } as never
 
-/** Shared helper: sets up mocks, runs command, asserts outputs for a single editor. */
-async function runEditorTest(tc: EditorTestCase): Promise<void> {
-  const originalPlatform = process.platform
-  const envBackups: Record<string, string | undefined> = {}
-
-  try {
-    // Platform override
-    if (tc.detect.overridePlatform) {
-      Object.defineProperty(process, 'platform', {value: tc.detect.overridePlatform})
-    }
-
-    // Env var overrides
-    if (tc.detect.env) {
-      for (const [key, value] of Object.entries(tc.detect.env)) {
-        envBackups[key] = process.env[key]
-        process.env[key] = value
-      }
-    }
-
-    // existsSync mock
-    if (tc.detect.existsSync) {
-      const predicate = tc.detect.existsSync
-      mockExistsSync.mockImplementation((p: PathLike) => predicate(String(p)))
-    }
-
-    // CLI mock — resolve for specific commands, reject for everything else
-    if (tc.detect.cliCommands) {
-      const commands = tc.detect.cliCommands
-      mockExeca.mockImplementation((async (command: string | URL) => {
-        if (commands.includes(String(command))) return EXECA_SUCCESS
-        throw new Error('Not installed')
-      }) as never)
-    }
-
-    mockCheckbox.mockResolvedValue([tc.name])
-
-    const token = `test-token-${tc.name.toLowerCase().replaceAll(/\s+/g, '-')}`
-
-    if (!tc.oauthOnly) {
-      mockMCPTokenCreation(token)
-    }
-
-    const {stdout} = await testCommand(ConfigureMcpCommand, [])
-
-    // Assert config was written to the expected path with the token
-    expect(mockWriteFile).toHaveBeenCalledWith(
-      expect.stringContaining(convertToSystemPath(tc.expectedConfigPath)),
-      tc.oauthOnly ? expect.not.stringContaining(token) : expect.stringContaining(token),
-      'utf8',
-    )
-
-    // Assert extra content checks
-    if (tc.expectedContentChecks) {
-      const writtenContent = mockWriteFile.mock.calls[0]?.[1] as string
-      for (const check of tc.expectedContentChecks) {
-        expect(writtenContent, `written content should contain "${check}"`).toContain(check)
-      }
-    }
-
-    expect(stdout).toContain(`MCP configured for ${tc.name}`)
-  } finally {
-    // Restore platform
-    if (tc.detect.overridePlatform) {
-      Object.defineProperty(process, 'platform', {value: originalPlatform})
-    }
-    // Restore env vars
-    for (const [key, original] of Object.entries(envBackups)) {
-      if (original === undefined) {
-        delete process.env[key]
-      } else {
-        process.env[key] = original
-      }
-    }
-  }
-}
-
-// ---------------------------------------------------------------------------
-// Test cases — one entry per editor/variant
-// ---------------------------------------------------------------------------
-
-const editorTestCases: EditorTestCase[] = [
-  {
-    detect: {existsSync: (p) => p.endsWith('.cursor')},
-    expectedConfigPath: '.cursor/mcp.json',
-    name: 'Cursor',
-    oauthOnly: true,
-  },
-  {
-    detect: {
-      existsSync: (p) => p.endsWith('Code/User'),
-      overridePlatform: 'darwin',
-    },
-    expectedConfigPath: 'Code/User/mcp.json',
-    name: 'VS Code',
-    platform: 'darwin',
-  },
-  {
-    detect: {
-      env: {APPDATA: String.raw`C:\Users\test\AppData\Roaming`},
-      existsSync: (p) => p.includes(String.raw`AppData\Roaming\Code\User`),
-      overridePlatform: 'win32',
-    },
-    expectedConfigPath: String.raw`AppData\Roaming\Code\User\mcp.json`,
-    name: 'VS Code',
-    platform: 'win32',
-  },
-  {
-    detect: {
-      existsSync: (p) => p.endsWith('Code - Insiders/User'),
-      overridePlatform: 'darwin',
-    },
-    expectedConfigPath: 'Code - Insiders/User/mcp.json',
-    name: 'VS Code Insiders',
-    platform: 'darwin',
-  },
-  {
-    detect: {
-      env: {APPDATA: String.raw`C:\Users\test\AppData\Roaming`},
-      existsSync: (p) => p.includes(String.raw`AppData\Roaming\Code - Insiders\User`),
-      overridePlatform: 'win32',
-    },
-    expectedConfigPath: String.raw`AppData\Roaming\Code - Insiders\User\mcp.json`,
-    name: 'VS Code Insiders',
-    platform: 'win32',
-  },
-  {
-    detect: {cliCommands: ['claude']},
-    expectedConfigPath: '.claude.json',
-    name: 'Claude Code',
-    oauthOnly: true,
-  },
-  {
-    detect: {
-      existsSync: (p) => {
-        const n = p.replaceAll('\\', '/')
-        return n.endsWith('/.gemini/antigravity')
-      },
-    },
-    expectedConfigPath: '.gemini/antigravity/mcp_config.json',
-    expectedContentChecks: ['serverUrl'],
-    name: 'Antigravity',
-  },
-  {
-    detect: {
-      existsSync: (p) => {
-        const n = p.replaceAll('\\', '/')
-        return n.endsWith('/Code/User/globalStorage/saoudrizwan.claude-dev/settings')
-      },
-    },
-    expectedConfigPath:
-      'Code/User/globalStorage/saoudrizwan.claude-dev/settings/cline_mcp_settings.json',
-    name: 'Cline',
-  },
-  {
-    detect: {
-      env: {
-        CLINE_DIR:
-          process.platform === 'win32'
-            ? String.raw`C:\tmp\custom-cline-home`
-            : '/tmp/custom-cline-home',
-      },
-      existsSync: (p) => {
-        const n = p.replaceAll('\\', '/')
-        return n.endsWith('/tmp/custom-cline-home')
-      },
-    },
-    expectedConfigPath: convertToSystemPath(
-      '/tmp/custom-cline-home/data/settings/cline_mcp_settings.json',
-    ),
-    name: 'Cline CLI',
-  },
-  {
-    detect: {
-      existsSync: (p) => {
-        const n = p.replaceAll('\\', '/')
-        return n.endsWith('/.gemini/settings.json')
-      },
-    },
-    expectedConfigPath: '.gemini/settings.json',
-    name: 'Gemini CLI',
-  },
-  {
-    detect: {
-      existsSync: (p) => {
-        const n = p.replaceAll('\\', '/')
-        return /\/.?copilot(?:\/|$)/.test(n)
-      },
-    },
-    expectedConfigPath: 'mcp-config.json',
-    expectedContentChecks: ['"tools"'],
-    name: 'GitHub Copilot CLI',
-  },
-  {
-    detect: {
-      env: {XDG_CONFIG_HOME: '/home/user/.config'},
-      existsSync: (p) => p.includes('/home/user/.config/copilot'),
-    },
-    expectedConfigPath: '/home/user/.config/copilot/mcp-config.json',
-    name: 'GitHub Copilot CLI',
-    platform: 'linux',
-  },
-  {
-    detect: {cliCommands: ['opencode'], overridePlatform: 'darwin'},
-    expectedConfigPath: '.config/opencode/opencode.json',
-    name: 'OpenCode',
-    platform: 'darwin',
-  },
-  {
-    detect: {cliCommands: ['codex']},
-    expectedConfigPath: '.codex/config.toml',
-    expectedContentChecks: ['[mcp_servers.Sanity]', '[mcp_servers.Sanity.http_headers]'],
-    name: 'Codex CLI',
-  },
-  {
-    detect: {
-      cliCommands: ['codex'],
-      env: {
-        CODEX_HOME:
-          process.platform === 'win32'
-            ? String.raw`C:\tmp\custom-codex-home`
-            : '/tmp/custom-codex-home',
-      },
-    },
-    expectedConfigPath: convertToSystemPath('/tmp/custom-codex-home/config.toml'),
-    name: 'Codex CLI',
-  },
-  {
-    detect: {
-      existsSync: (p) => p.includes('.config/zed'),
-      overridePlatform: 'darwin',
-    },
-    expectedConfigPath: '.config/zed/settings.json',
-    name: 'Zed',
-    platform: 'darwin',
-  },
-  {
-    detect: {
-      env: {APPDATA: String.raw`C:\Users\test\AppData\Roaming`},
-      existsSync: (p) => p.includes(String.raw`AppData\Roaming\Zed`),
-      overridePlatform: 'win32',
-    },
-    expectedConfigPath: String.raw`AppData\Roaming\Zed\settings.json`,
-    name: 'Zed',
-    platform: 'win32',
-  },
-]
-
-// MCPorter has three variants for file format detection
-const mcporterTestCases: Array<{
-  existsSync: (p: string) => boolean
-  expectedConfigPath: string
-  label: string
-}> = [
-  {
-    existsSync: (p) => {
-      const n = p.replaceAll('\\', '/')
-      if (n.endsWith('/.mcporter')) return true
-      if (n.endsWith('/.mcporter/mcporter.json')) return false
-      if (n.endsWith('/.mcporter/mcporter.jsonc')) return true
-      return false
-    },
-    expectedConfigPath: '.mcporter/mcporter.jsonc',
-    label: 'existing jsonc config',
-  },
-  {
-    existsSync: (p) => {
-      const n = p.replaceAll('\\', '/')
-      if (n.endsWith('/.mcporter')) return true
-      if (n.endsWith('/.mcporter/mcporter.json')) return true
-      if (n.endsWith('/.mcporter/mcporter.jsonc')) return false
-      return false
-    },
-    expectedConfigPath: '.mcporter/mcporter.json',
-    label: 'existing json config',
-  },
-  {
-    existsSync: (p) => {
-      const n = p.replaceAll('\\', '/')
-      if (n.endsWith('/.mcporter')) return true
-      if (n.endsWith('/.mcporter/mcporter.json')) return false
-      if (n.endsWith('/.mcporter/mcporter.jsonc')) return false
-      return false
-    },
-    expectedConfigPath: '.mcporter/mcporter.json',
-    label: 'fresh install (defaults to json)',
-  },
-]
-
 // ---------------------------------------------------------------------------
 // Main test suite
 // ---------------------------------------------------------------------------
@@ -434,30 +121,6 @@ describe.sequential('#mcp:configure', () => {
     expect(pending, 'pending mocks').toEqual([])
   })
 
-  // -------------------------------------------------------------------------
-  // Per-editor detection (table-driven)
-  // -------------------------------------------------------------------------
-
-  describe('editor detection and configuration', () => {
-    for (const tc of editorTestCases) {
-      const suffix = tc.platform ? ` on ${tc.platform}` : ''
-      const envNote = tc.detect.env ? ` (${Object.keys(tc.detect.env).join(', ')})` : ''
-      const label = `detects ${tc.name}${suffix}${envNote} and configures it`
-
-      test.runIf(!tc.platform || process.platform === tc.platform)(label, () => runEditorTest(tc))
-    }
-
-    // MCPorter file-format variants
-    for (const mc of mcporterTestCases) {
-      test(`detects MCPorter with ${mc.label} and configures it`, () =>
-        runEditorTest({
-          detect: {existsSync: mc.existsSync},
-          expectedConfigPath: mc.expectedConfigPath,
-          name: 'MCPorter',
-        }))
-    }
-  })
-
   // -------------------------------------------------------------------------
   // Codex CLI: unparseable TOML skips editor
   // -------------------------------------------------------------------------