test(chore): move module URL tests to the right place

Author: filmaj

packages/@sanity/cli-build/src/actions/build/__tests__/getAutoUpdatesImportMap.test.ts

@@ -1,6 +1,10 @@
 import {describe, expect, test} from 'vitest'
 
-import {getAutoUpdatesCssUrls, getAutoUpdatesImportMap} from '../getAutoUpdatesImportMap.js'
+import {
+  getAutoUpdatesCssUrls,
+  getAutoUpdatesImportMap,
+  getModuleUrl,
+} from '../getAutoUpdatesImportMap.js'
 
 describe('getAutoUpdateImportMap() without app id', () => {
   test('works with sanity package', () => {
@@ -151,3 +155,24 @@ describe('getAutoUpdatesCssUrls() with app id', () => {
     ])
   })
 })
+
+describe('getModuleUrl', () => {
+  test('should use the default module endpoint when no appId is provided', () => {
+    const res = getModuleUrl({name: 'sanity', version: '3.40.0'})
+
+    expect(res).toContain('/v1/modules/sanity/default/')
+    expect(res).not.toContain('/by-app/')
+  })
+
+  test('should use the app-specific module endpoint when appId is provided', () => {
+    const res = getModuleUrl(
+      {name: 'sanity', version: '3.40.0'},
+      {
+        appId: 'my-app-id',
+      },
+    )
+
+    expect(res).toContain('/v1/modules/by-app/my-app-id/')
+    expect(res).not.toContain('/default/')
+  })
+})

packages/@sanity/cli/src/util/__tests__/compareDependencyVersions.test.ts

@@ -5,14 +5,19 @@ import {compareDependencyVersions} from '../compareDependencyVersions'
 const mockReadPackageJson = vi.hoisted(() => vi.fn())
 const mockRequest = vi.hoisted(() => vi.fn())
 const mockGetLocalPackageVersion = vi.hoisted(() => vi.fn())
+const mockGetModuleUrl = vi.hoisted(() => vi.fn())
 
 vi.mock('@sanity/cli-core/util/getLocalPackageVersion', () => ({
   getLocalPackageVersion: mockGetLocalPackageVersion,
 }))
 vi.mock('@sanity/cli-core/util/readPackageJson', () => ({
   readPackageJson: mockReadPackageJson,
 }))
-// TODO: mock getModuleUrl
+vi.mock('@sanity/cli-build/_internal/actions/build/getAutoUpdatesImportMap', () => ({
+  getAutoUpdatesCssUrls: vi.fn(),
+  getAutoUpdatesImportMap: vi.fn(),
+  getModuleUrl: mockGetModuleUrl,
+}))
 
 const autoUpdatePackages = [
   {name: 'sanity', version: '1.0.0'},
@@ -465,50 +470,6 @@ describe('compareDependencyVersions', () => {
     })
   })
 
-  describe('module URL selection', () => {
-    it('should use the default module endpoint when no appId is provided', async () => {
-      mockRequest.mockResolvedValue({
-        headers: {'x-resolved-version': '3.40.0'},
-        statusCode: 302,
-      })
-      mockGetLocalPackageVersion.mockResolvedValue('3.40.0')
-      mockReadPackageJson.mockResolvedValueOnce({
-        dependencies: {sanity: '^3.40.0'},
-        devDependencies: {},
-        name: 'test-package',
-        version: '0.0.0',
-      })
-
-      await compare([{name: 'sanity', version: '3.40.0'}], '/test/workdir')
-
-      const url = mockRequest.mock.calls[0][0].url as string
-      expect(url).toContain('/v1/modules/sanity/default/')
-      expect(url).not.toContain('/by-app/')
-    })
-
-    it('should use the app-specific module endpoint when appId is provided', async () => {
-      mockRequest.mockResolvedValue({
-        headers: {'x-resolved-version': '3.40.0'},
-        statusCode: 302,
-      })
-      mockGetLocalPackageVersion.mockResolvedValue('3.40.0')
-      mockReadPackageJson.mockResolvedValueOnce({
-        dependencies: {sanity: '^3.40.0'},
-        devDependencies: {},
-        name: 'test-package',
-        version: '0.0.0',
-      })
-
-      await compare([{name: 'sanity', version: '3.40.0'}], '/test/workdir', {
-        appId: 'my-app-id',
-      })
-
-      const url = mockRequest.mock.calls[0][0].url as string
-      expect(url).toContain('/v1/modules/by-app/my-app-id/')
-      expect(url).not.toContain('/default/')
-    })
-  })
-
   describe('prerelease version handling', () => {
     it('should return prerelease package in unresolvedPrerelease when remote returns 404', async () => {
       mockRequest.mockResolvedValue({

packages/@sanity/cli/src/util/compareDependencyVersions.ts

@@ -1,6 +1,6 @@
 import path from 'node:path'
 
-import {getModuleUrl} from '@sanity/cli-build/_internal/build'
+import {getModuleUrl} from '@sanity/cli-build/_internal/actions/build/getAutoUpdatesImportMap'
 import {createRequester} from '@sanity/cli-core/request'
 import {getLocalPackageVersion} from '@sanity/cli-core/util/getLocalPackageVersion'
 import {readPackageJson} from '@sanity/cli-core/util/readPackageJson'