Merge pull request #40 from sanketsudake/cask/postflight-steps

cask: emit postflight_steps instead of the deprecated postflight

Author: sanketsudake

.github/workflows/ci.yml

@@ -93,3 +93,26 @@ jobs:
         run: nix build .#chrome-cdp --print-build-logs
       - name: Smoke-test the built binary
         run: ./result/bin/chrome-cdp --version
+
+  # The Homebrew cask this repo publishes is generated from .goreleaser.yaml, so
+  # a mistake in the homebrew_casks block otherwise surfaces at tag time, inside
+  # a release. `check` validates the config on every push instead.
+  #
+  # The schema probe is the trigger for dropping the custom_block workaround:
+  # `hooks.post.install_steps` is unreleased (goreleaser#6873), and this warns
+  # on the first push after it lands.
+  goreleaser:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: goreleaser/goreleaser-action@v6
+        with:
+          version: "~> v2"
+          args: check
+
+      - name: Notice when hooks.post.install_steps ships
+        run: |
+          if goreleaser schema | jq -e '.["$defs"].HomebrewCaskHook.properties.install_steps' >/dev/null; then
+            echo "::warning::hooks.post.install_steps is available — migrate off custom_block (goreleaser#6873)"
+          fi

.goreleaser.yaml

@@ -81,11 +81,29 @@ homebrew_casks:
       token: "{{ .Env.HOMEBREW_TAP_GITHUB_TOKEN }}"
     directory: Casks
     homepage: "https://github.com/sanketsudake/chrome-cdp-cli"
-    description: "Drive your already-running local Chrome from the command line over CDP"
+    description: "Drive your already-running local Chrome from the command-line over CDP"
     # Strip the quarantine xattr so the unsigned binary runs without a Gatekeeper prompt.
-    hooks:
-      post:
-        install: |
-          if system_command("/usr/bin/xattr", args: ["-h"]).exit_status == 0
-            system_command "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "#{staged_path}/chrome-cdp"]
-          end
+    #
+    # This is the body GoReleaser's own deprecation notice prescribes for
+    # hooks.post.install_steps, but that key ships in v2.19; until then the only
+    # way to emit `postflight_steps` is custom_block, because GoReleaser still
+    # wraps hooks.post.install in Homebrew's deprecated `postflight`.
+    # The {{ "..." }} escape is needed because GoReleaser templates the rendered
+    # cask once, and would otherwise read {{staged_path}} as one of its own
+    # template calls.
+    #
+    # TODO(goreleaser#6873): on v2.19, delete custom_block and use
+    #   hooks:
+    #     post:
+    #       install_steps: |
+    #         on_macos do
+    #           run "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "{{ .StagedPath }}/chrome-cdp"], must_succeed: false
+    #         end
+    custom_block: |
+      postflight_steps do
+        on_macos do
+          run "/usr/bin/xattr",
+              args:         ["-dr", "com.apple.quarantine", "{{ "{{staged_path}}" }}/chrome-cdp"],
+              must_succeed: false
+        end
+      end