clippy: fix warnings

Author: santhosh-tekuri

Cargo.toml

@@ -35,3 +35,6 @@ criterion = "0.5"
 [[bench]]
 name = "bench"
 harness = false
+
+[lints.clippy]
+result_large_err = "allow"

src/ecma.rs

@@ -5,7 +5,7 @@ use regex_syntax::ast::{self, *};
 
 // covert ecma regex to rust regex if possible
 // see https://262.ecma-international.org/11.0/#sec-regexp-regular-expression-objects
-pub(crate) fn convert(pattern: &str) -> Result<Cow<str>, Box<dyn std::error::Error>> {
+pub(crate) fn convert(pattern: &str) -> Result<Cow<'_, str>, Box<dyn std::error::Error>> {
     let mut pattern = Cow::Borrowed(pattern);
 
     let mut ast = loop {

src/output.rs

@@ -35,7 +35,7 @@ impl<'s> ValidationError<'s, '_> {
     }
 
     /// The `Basic` structure, a flat list of output units.
-    pub fn basic_output(&self) -> OutputUnit {
+    pub fn basic_output(&self) -> OutputUnit<'_, '_, '_> {
         let mut outputs = vec![];
 
         let mut in_ref = InRef::default();
@@ -86,7 +86,7 @@ impl<'s> ValidationError<'s, '_> {
     }
 
     /// The `Detailed` structure, based on the schema.
-    pub fn detailed_output(&self) -> OutputUnit {
+    pub fn detailed_output(&self) -> OutputUnit<'_, '_, '_> {
         let mut root = None;
         let mut stack: Vec<OutputUnit> = vec![];
 

src/util.rs

@@ -18,7 +18,7 @@ use crate::CompileError;
 pub(crate) struct JsonPointer(pub(crate) String);
 
 impl JsonPointer {
-    pub(crate) fn escape(token: &str) -> Cow<str> {
+    pub(crate) fn escape(token: &str) -> Cow<'_, str> {
         const SPECIAL: [char; 2] = ['~', '/'];
         if token.contains(SPECIAL) {
             token.replace('~', "~0").replace('/', "~1").into()
@@ -27,7 +27,7 @@ impl JsonPointer {
         }
     }
 
-    pub(crate) fn unescape(mut tok: &str) -> Result<Cow<str>, ()> {
+    pub(crate) fn unescape(mut tok: &str) -> Result<Cow<'_, str>, ()> {
         let Some(mut tilde) = tok.find('~') else {
             return Ok(Cow::Borrowed(tok));
         };
@@ -332,7 +332,7 @@ where
         .join(sep)
 }
 
-pub(crate) fn escape(token: &str) -> Cow<str> {
+pub(crate) fn escape(token: &str) -> Cow<'_, str> {
     JsonPointer::escape(token)
 }
 

src/validator.rs

@@ -996,7 +996,7 @@ impl Scope<'_> {
         }
     }
 
-    fn check_cycle(&self) -> Option<&Scope> {
+    fn check_cycle(&self) -> Option<&Scope<'_>> {
         let mut scope = self.parent;
         while let Some(scp) = scope {
             if scp.vid != self.vid {

tests/examples.rs

@@ -169,7 +169,7 @@ fn example_custom_content_encoding() -> Result<(), Box<dyn Error>> {
         }
     }
     fn decode_hex(s: &str) -> Result<Vec<u8>, Box<dyn Error>> {
-        if s.len() % 2 != 0 {
+        if !s.len().is_multiple_of(2) {
             Err("decode_hex: odd length")?;
         }
         let mut bytes = s.bytes();