Fails to rebuild for electron 28+ (v8 12+)

[chrbongardt]

V8 v12 brings some breaking changes to the ObjectTemplate::SetAccessor signature. NAN is working on a fix: nodejs/nan#966.

As soon as the fixing NAN version is released I will open a PR. Just wanted to have this tracked.

Thanks!

[chrbongardt]

Done, I just created PR #102 that should fix this.

[chrbongardt]

While this get's merged and released by @santigimeno you can use my branch by doing
npm i git@github.com:chrbongardt/node-pcsclite.git#master

• Tested up to electron v29!

[rkeithhill-keysight]

Huh, nan 2.19.0 does not fix this issue for Electon 28 builds. I still get:

'v8::ObjectTemplate::SetAccessor': no overloaded function could convert all the argument types

[crudolf]

@santigimeno would be awesome to have new release here ❤️

[ayZagen]

the mentioned fix does not work with electron 30+. It seems unlikely but I hope we see a new version with n-api instead of nan.