sap_software_download: alternative download logic enhancement

[sean-freeman]

sap_software_download: alternative download logic enhancement

When an old SAP HANA release (e.g. SPS07) is replaced, the matching SAP HANA Components (LCAPPS, AFL etc) for that version are not replaced in SAP Download Center.

This results in a circumstance where the download list may correctly identify a later replacement for SAP HANA (e.g. SPS09), but this will not force SAP HANA Components later versions to be validated. Leading to the following failures.

The impact for this, is any older software version currently under AP4S project will not have the correct file and an execution will fail (and problem for the end-user which was not seen before, as the AP4S GH Action to periodically update software has now been disabled due to upgrades in this Ansible Role)

TASK [community.sap_launchpad.sap_software_download : Relationship Validation - Dry run to check availability of files with Python venv] ***
task path: /community/sap_launchpad/roles/sap_software_download/tasks/pre_steps/05_validate_relations.yml:8

ok: [sap-nwas] => (item=IMDB_SERVER20_077_0-80002031.SAR : Alternative SAP Software is available to download: IMDB_SERVER20_079_8-80002031.SAR - original file IMDB_SERVER20_077_0-80002031.SAR is not available) => {"alternative": true, "ansible_loop_var": "item", "attempts": 1, "changed": false, "filename": "IMDB_SERVER20_079_8-80002031.SAR", "item": "IMDB_SERVER20_077_0-80002031.SAR", "msg": "Alternative SAP Software is available to download: IMDB_SERVER20_079_8-80002031.SAR - original file IMDB_SERVER20_077_0-80002031.SAR is not available"}
ok: [sap-nwas] => (item=IMDB_LCAPPS_2077_3-20010426.SAR : SAP Software is available to download: IMDB_LCAPPS_2077_3-20010426.SAR) => {"alternative": false, "ansible_loop_var": "item", "attempts": 1, "changed": false, "filename": "IMDB_LCAPPS_2077_3-20010426.SAR", "item": "IMDB_LCAPPS_2077_3-20010426.SAR", "msg": "SAP Software is available to download: IMDB_LCAPPS_2077_3-20010426.SAR"}
ok: [sap-nwas] => (item=IMDB_AFL20_077_0-80001894.SAR : SAP Software is available to download: IMDB_AFL20_077_0-80001894.SAR) => {"alternative": false, "ansible_loop_var": "item", "attempts": 1, "changed": false, "filename": "IMDB_AFL20_077_0-80001894.SAR", "item": "IMDB_AFL20_077_0-80001894.SAR", "msg": "SAP Software is available to download: IMDB_AFL20_077_0-80001894.SAR"}
....
....
....
TASK [community.sap_launchpad.sap_software_download : Relationship Validation - SAP HANA 2.00 - Set HANA variables] ***
task path: /community/sap_launchpad/roles/sap_software_download/tasks/pre_steps/07_validate_sap_hana_2.yml:4

ok: [sap-nwas] => {"ansible_facts": {"__sap_software_download_sap_hana_2_version": "079"}, "changed": false}

TASK [community.sap_launchpad.sap_software_download : Relationship Validation - SAP HANA 2.00 - IMDB_SERVER and IMDB_LCAPPS] ***
task path: /community/sap_launchpad/roles/sap_software_download/tasks/pre_steps/07_validate_sap_hana_2.yml:17

FATAL_ERROR: [sap-nwas]: FAILED! => {"changed": false, "msg": "Warning: Incompatible SAP HANA component LCAPPS files were found for detected SAP HANA DATABASE 2.0 SPS 07 Revision 079.\n\nExpected file pattern: IMDB_LCAPPS_2079*\nActual files detected: IMDB_LCAPPS_2077_3-20010426.SAR\n"}

[marcelmamula]

@sean-freeman Very interesting problem, but I am happy that it was caught by this workflow as it served its purpose.

After looking at SAP Download Center I can see more variations as in example case of LCAPPS there are patches as well (P in name). Those are not covered by current relationship logic either. Example: IMDB_LCAPPS_2079P_100-20010426.SAR

There could be secondary workflow for checking alternatives for HANA components if IMDB_SERVER was also alternative, but I see potential issue:

• Idempotent execution on host where IMDB_SERVER was discontinued between executions will have 2 component versions, which would pass relationship check, but will HANA install load only correct one?

[marcelmamula]

Further testing showed something similar with Patch 1 being discontinued only for IMDB_SERVER, but not for components.

Will have to take that into account as well.

TASK [community.sap_launchpad.sap_software_download : Relationship Validation - Dry run to check availability of files with Python system default] *********
 [started TASK: community.sap_launchpad.sap_software_download : Relationship Validation - Dry run to check availability of files with Python system default on s02pas]
ok: [s02pas] => (item=IMDB_SERVER20_089_1-80002031.SAR : Alternative SAP Software is available to download: IMDB_SERVER20_089_2-80002031.SAR - original file IMDB_SERVER20_089_1-80002031.SAR is not available)
skipping: [s02pas] => (item=IMDB_LCAPPS_2089P_101-20010426.SAR : File already exists: IMDB_LCAPPS_2089P_101-20010426.SAR)
skipping: [s02pas] => (item=IMDB_AFL20_089P_100-80001894.SAR : File already exists: IMDB_AFL20_089P_100-80001894.SAR)

TASK [community.sap_launchpad.sap_software_download : Relationship Validation - SAP HANA 2.00 - IMDB_SERVER and IMDB_LCAPPS] *******************************
 [started TASK: community.sap_launchpad.sap_software_download : Relationship Validation - SAP HANA 2.00 - IMDB_SERVER and IMDB_LCAPPS on s02pas]
skipping: [s02pas]

    stderr: |-
        Configuration error (batch mode):
          Selected component SAP HANA LCAPPS is not compatible with SAP HANA Database version '2.00.089.02.1774343488'. The SAP HANA LCAPPS '2.00.089.0101.1771353361' requires SAP HANA Database version 2.00.089.01.1769502981

[marcelmamula]

Also add regex to run dry run collection only for those that implemented. Regex with ^IMDB_* for example.