Add no_slug parameter (to use name instead of slug) (#18)

* Add no_slug parameter (to use name instead of slug)

* Rename get_value_type_field to get_slug_field for clarity

Author: stefanhipfel

netbox_atlas_plugin/api/labels.py

@@ -1,6 +1,6 @@
 class LabelDict(dict):
 
-    def add_netbox_labels(self, obj, target_name=None):
+    def add_netbox_labels(self, obj, target_name=None, value_type="slug"):
         self.__setitem__('server_id', str(obj.id))
         if getattr(obj, "status", None) is not None:
             self.__setitem__('status', obj.status)
@@ -16,29 +16,29 @@ def add_netbox_labels(self, obj, target_name=None):
                 self.__setitem__('name', f"{obj.name}-{target_name}")
 
         if getattr(obj, "device_type", None) is not None:
-            self.__setitem__('manufacturer', obj.device_type.manufacturer.slug)
-            self.__setitem__('device_type', obj.device_type.slug)
+            self.__setitem__('manufacturer', getattr(obj.device_type.manufacturer, value_type, ""))
+            self.__setitem__('device_type', getattr(obj.device_type, value_type, ""))
             if getattr(obj.device_type, "model", None) is not None:
                 self.__setitem__('model', obj.device_type.model)
 
         if getattr(obj, "role", None) is not None:
-            self.__setitem__('role', obj.role.slug)
+            self.__setitem__('role', getattr(obj.role, value_type, ""))
 
         if getattr(obj, "site", None) is not None:
-            self.__setitem__('site', obj.site.slug)
+            self.__setitem__('site', getattr(obj.site, value_type, ""))
 
         if getattr(obj, "platform", None) is not None:
-            self.__setitem__('platform', obj.platform.slug)
+            self.__setitem__('platform', getattr(obj.platform, value_type, ""))
 
         if getattr(obj, "serial", None) is not None:
             self.__setitem__('serial', obj.serial)
 
         if getattr(obj, "cluster", None) is not None:
             self.__setitem__("cluster",  obj.cluster.name)
             if obj.cluster.group:
-                self.__setitem__("cluster_group",  obj.cluster.group.slug)
+                self.__setitem__("cluster_group", getattr(obj.cluster.group, value_type, ""))
             if obj.cluster.type:
-                self.__setitem__("cluster_type", obj.cluster.type.slug)
+                self.__setitem__("cluster_type", getattr(obj.cluster.type, value_type, ""))
 
     def add_metrics_label(self, value):
         if value != '':

netbox_atlas_plugin/api/serializers.py

@@ -22,6 +22,10 @@ def get_target_field(self):
     @cached_property
     def get_metrics_field(self):
         return self.context['request'].query_params.get('metrics_label', '')
+    
+    @cached_property
+    def get_slug_field(self):
+        return "slug" if self.context['request'].query_params.get('no_slug', True) else "name"
 
     @cached_property
     def get_custom_fields(self):
@@ -78,9 +82,9 @@ def get_labels(self, dv):
         labels = LabelDict()
 
         if self.context['request'].query_params.get('target_in_name', False):
-            labels.add_netbox_labels(dv, None)
+            labels.add_netbox_labels(dv, None, self.get_slug_field)
         else:
-            labels.add_netbox_labels(dv, self.get_target_field)
+            labels.add_netbox_labels(dv, self.get_target_field, self.get_slug_field)
         labels.add_custom_labels(self.get_custom_fields)
         labels.add_custom_labels(self.get_configcontext(dv))
         labels.add_custom_labels(self.get_url(dv))