Skip to content
This repository was archived by the owner on May 29, 2020. It is now read-only.
This repository was archived by the owner on May 29, 2020. It is now read-only.

Update ttf2woff2 to v3 for Node v12 + support #394

@jleiva

Description

@jleiva

Hi!
When installing grunt-webfont in Node v12 there are some errors.

I'm using:

Node v12.0.0
npm v6.9.0
node-gyp -v v3.8.0

According to ttf2woff2 this was fixed in https://github.com/nfroidure/ttf2woff2/releases/tag/v3.0.0

Error
``

[email protected] install /Users/jdleiva/Workspaces/bc-frontend/public/node_modules/ttf2woff2
(node-gyp rebuild > builderror.log) || (exit 0)

../csrc/addon.cc:10:40: error: no matching member function for call to 'ToObject'
Local inputBuffer = info[0]->ToObject();
~~~~~~~~~^~~~~~~~
/Users/jdleiva/.node-gyp/12.0.0/include/node/v8.h:2532:44: note: candidate function not viable: requires single argument 'context', but no arguments were provided
V8_WARN_UNUSED_RESULT MaybeLocal ToObject(
^
/Users/jdleiva/.node-gyp/12.0.0/include/node/v8.h:2546:35: note: candidate function not viable: requires single argument 'isolate', but no arguments were provided
Local ToObject(Isolate* isolate) const);
^
1 error generated.
make: *** [Release/obj.target/addon/csrc/addon.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/jdleiva/.nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:196:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/Users/jdleiva/.nvm/versions/node/v12.0.0/bin/node" "/Users/jdleiva/.nvm/versions/node/v12.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/jdleiva/Workspaces/bc-frontend/public/node_modules/ttf2woff2
gyp ERR! node -v v12.0.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
``

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions