address Copilot review findings on PR #143

- Global Ctrl-Shift-` shortcut now reads the correct cookie name
  (gearbox_active_box, not box_id) and wires eagerly on
  DOMContentLoaded so it works before the user has opened the
  console once.
- Add .console-search-bar.hidden and .console-paste-modal.hidden to
  the .hidden specificity-override block; Tailwind's .hidden was
  losing the cascade tie to our component display rules.
- Paste threshold now counts actual newline characters (>= 20)
  rather than split('\n').length, removing the off-by-one and the
  trailing-newline edge case. Visible "N lines" label reads
  newlines + 1 to match how users count.
- Confirmed paste routes through term.paste(text) so xterm applies
  its normal paste pipeline including bracketed-paste wrapping
  (ESC[200~ ... ESC[201~) when the remote shell has DECSET 2004
  enabled. Direct sendText was bypassing that.
- Drop dead CSS rules targeting .xterm-decoration.console-search-*.
  The xterm-addon-search uses its own class names
  (xterm-find-result-decoration / xterm-find-active-result-decoration)
  and we already pass decorations.{activeMatchBackground,matchBackground}
  options in JS, so the CSS was unreachable.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: sarg3nt

gearbox/static/css/components/console.css

@@ -65,7 +65,9 @@ body.console-dock-open {
 .console-tool-btn.hidden,
 .console-tab-dot.hidden,
 .console-tab-new.hidden,
-.console-tab-bar.hidden {
+.console-tab-bar.hidden,
+.console-search-bar.hidden,
+.console-paste-modal.hidden {
 	display: none;
 }
 
@@ -292,9 +294,6 @@ body.console-dock-open {
 	justify-content: center;
 	padding: 24px;
 }
-.console-paste-modal.hidden {
-	display: none;
-}
 .console-paste-modal-panel {
 	background: rgb(15, 23, 42);
 	border: 1px solid rgb(51, 65, 85);
@@ -358,14 +357,6 @@ body.console-dock-open {
 	background: rgb(110, 231, 183);
 }
 
-/* xterm-addon-search highlight tweaks for our dark theme */
-.xterm .xterm-decoration.console-search-active {
-	background: rgba(250, 204, 21, 0.6);
-}
-.xterm .xterm-decoration.console-search-other {
-	background: rgba(250, 204, 21, 0.25);
-}
-
 /* ---------- xterm padding ---------- */
 
 /* xterm.js paints right up to its container's edges by default. The

gearbox/static/js/console/console.js

@@ -561,12 +561,15 @@
 
     /* ---------- paste confirm ---------- */
 
-    // Per #142 spec: ≥ 20 newlines triggers an inline confirm modal so a
-    // multi-command paste can't accidentally run the entire clipboard.
-    // Bracketed paste mode (DECSET 2004) is enabled by the remote shell;
+    // Per #142 spec: ≥ 20 newline characters in clipboard text triggers
+    // an inline confirm modal so a multi-command paste can't accidentally
+    // run the entire clipboard. We count actual '\n' occurrences (not
+    // lines) so a trailing newline doesn't shift the threshold off by one.
+    // Bracketed paste mode (DECSET 2004) is the remote shell's job;
     // xterm wraps pasted content with ESC[200~ … ESC[201~ automatically
-    // when the shell asked for it. This modal is the operator-side guard.
-    const PASTE_CONFIRM_LINES = 20;
+    // when the shell asked for it. Confirmed pastes route through
+    // term.paste() so that wrapping still happens.
+    const PASTE_CONFIRM_NEWLINES = 20;
 
     ConsoleManager.prototype._wirePasteConfirm = function () {
         const modal = this._$('console-paste-modal');
@@ -589,7 +592,14 @@
             const text = self._pendingPaste;
             closeModal();
             const s = self._active();
-            if (text && s) s.sendText(text);
+            // Route through term.paste() so xterm applies its normal
+            // paste pipeline (bracketed-paste wrapping, normalization).
+            // sendText would bypass DECSET 2004 framing.
+            if (text && s && s.term && typeof s.term.paste === 'function') {
+                s.term.paste(text);
+            } else if (text && s) {
+                s.sendText(text);
+            }
         });
 
         // Listen at document level so paste lands here before xterm's
@@ -605,14 +615,21 @@
             if (!e.clipboardData) return;
             const text = e.clipboardData.getData('text');
             if (!text) return;
-            const lines = text.split('\n').length;
-            if (lines < PASTE_CONFIRM_LINES) return; // let xterm handle it normally
+            // Count actual newline characters — robust against trailing-newline
+            // quirks vs. counting lines via split().length.
+            let newlines = 0;
+            for (let i = 0; i < text.length; i++) {
+                if (text.charCodeAt(i) === 10) newlines++;
+            }
+            if (newlines < PASTE_CONFIRM_NEWLINES) return; // let xterm handle it normally
             e.preventDefault();
             e.stopPropagation();
             self._pendingPaste = text;
             const linesEl = self._$('console-paste-modal-lines');
             const previewEl = self._$('console-paste-modal-preview');
-            if (linesEl) linesEl.textContent = String(lines);
+            // Visible "N lines" count = newlines + 1 (the line after the
+            // final newline). Matches how the user thinks about it.
+            if (linesEl) linesEl.textContent = String(newlines + 1);
             if (previewEl) {
                 // Cap preview at ~1200 chars + first ~30 lines so a huge
                 // paste doesn't blow up the modal. textContent is safe.
@@ -628,17 +645,23 @@
     /* ---------- global shortcut ---------- */
 
     // Ctrl-Shift-` opens the console for the active box. Reads box_id from
-    // the cookie set by switchBox; no cookie → no-op (palette is the
-    // fallback path for users who haven't pinned a box yet).
+    // the gearbox_active_box cookie set by the box-resolver middleware;
+    // no cookie → no-op (palette is the fallback path for users who
+    // haven't pinned a box yet).
+    //
+    // Registered eagerly on DOMContentLoaded — must not depend on the
+    // user having opened the console at least once.
     ConsoleManager.prototype._wireGlobalShortcut = function () {
+        if (this._globalShortcutWired) return;
+        this._globalShortcutWired = true;
         const self = this;
         document.addEventListener('keydown', function (e) {
             if (!e.ctrlKey || !e.shiftKey || e.altKey || e.metaKey) return;
             // Match both literal backtick and "Backquote" code so Dvorak
             // and other non-QWERTY layouts work too.
             if (e.key !== '`' && e.code !== 'Backquote') return;
             e.preventDefault();
-            const boxID = readCookie('box_id');
+            const boxID = readCookie('gearbox_active_box');
             if (!boxID) return;
             self.open({ kind: 'box', boxID: boxID, label: boxID });
         });
@@ -1094,6 +1117,19 @@
         manager: manager,
     };
 
+    // Eagerly wire the global Ctrl-Shift-` shortcut so it works even
+    // before the user has opened the console once. Other wiring (dock
+    // resize, search bar, paste modal) needs the drawer markup present
+    // and stays inside the lazy _wire() path.
+    function eagerWire() {
+        try { manager._wireGlobalShortcut(); } catch (_) {}
+    }
+    if (document.readyState === 'loading') {
+        document.addEventListener('DOMContentLoaded', eagerWire);
+    } else {
+        eagerWire();
+    }
+
     window.gearbox.console.markPopout = function () {
         manager.popoutMode = true;
         manager.layout = 'drawer';