Commit bc7f99a
fix(#103): remove height:100% from inner card — was eating the row gap
Diagnosed via Chrome MCP direct DOM inspection. Three rules were
fighting over the inner card's size:
GridStack vendor CSS → position: absolute; top: 24px; bottom: 24px
My rule on #charts-grid → height: 100%
CSS spec when over-constrained → height wins
Resolved: inner ended up 320px tall (matching outer's full height)
anchored at top:24, so it extended 24px BELOW the outer's bottom —
exactly where the next row's outer begins. Visual result: zero gap
between adjacent rows' inner cards, no matter what margin value I
set on the GridStack init. That's why margins 18, 24, 36 all looked
identical — the cells were always butting up against each other.
Fix: drop the `height: 100%`. GridStack's inline top + bottom is
sufficient to size the absolute-positioned inner content (inner
height becomes outer_height − marginTop − marginBottom = 272px for
gs-h=4, leaving a 48px gap between rows that matches the configured
margins).
Verified via Chrome MCP after fix:
inner height: 272 (was 320, was overrunning by 24)
visible gap between row 0 inner bottom and row 4 inner top: 48px
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 4040cab commit bc7f99a
1 file changed
Lines changed: 14 additions & 11 deletions
Lines changed: 14 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
449 | 449 | | |
450 | 450 | | |
451 | 451 | | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
462 | 466 | | |
463 | 467 | | |
464 | 468 | | |
465 | | - | |
466 | 469 | | |
467 | 470 | | |
468 | 471 | | |
| |||
0 commit comments