feat: wire remaining notifications; manual index off the shared DB lock

Notifications: the Agent Error and Task Completed toggles were dead
settings. Wire them (and the existing Review Completed) through one
notifyIfEnabled helper that respects each toggle's default:
- Review Completed -> review finishes (default on)
- Agent Error -> review or fix run fails (default on)
- Task Completed -> agent fix completes (default off)

Indexer: instead of holding the shared DbState connection lock for the
whole manual re-index, trigger_index now opens its own WAL connection
(the same pattern the periodic/startup indexer already uses) on a
blocking thread. With WAL + busy_timeout, other DB-backed commands stay
responsive during a cold index. The indexer logic itself is unchanged.

Bumps desktop app to 1.1.58.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: sarthakagrawal927

apps/desktop/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@code-reviewer/desktop",
-  "version": "1.1.57",
+  "version": "1.1.58",
   "private": true,
   "scripts": {
     "dev": "lsof -ti:1420 | xargs kill -9 2>/dev/null; vite",

apps/desktop/src-tauri/src/commands/history.rs

@@ -7,7 +7,7 @@ use serde::Serialize;
 use serde_json::{json, Value};
 use std::io::BufRead;
 use std::sync::Mutex;
-use tauri::{AppHandle, Emitter, State};
+use tauri::{AppHandle, Emitter, Manager, State};
 
 static FULL_INDEX_LOCK: Mutex<()> = Mutex::new(());
 
@@ -178,17 +178,20 @@ pub fn emit_session_archive_updated(app: &AppHandle, summary: &FullIndexSummary)
 }
 
 #[tauri::command]
-pub async fn trigger_index(app: AppHandle, db: State<'_, DbState>) -> Result<Value, String> {
-    // Run the full index on a blocking thread: it reads + parses every session
-    // JSONL and writes SQLite synchronously, which would otherwise stall the
-    // Tauri async runtime worker for the whole (cold) index.
-    let conn = db.0.clone();
+pub async fn trigger_index(app: AppHandle) -> Result<Value, String> {
+    // Index against a private WAL connection on a blocking thread — exactly the
+    // pattern the periodic/startup indexer already uses (main.rs:run_full_index).
+    // This keeps the full (cold) index off both the async runtime worker AND the
+    // shared DbState connection lock, so other DB-backed commands stay responsive
+    // during a manual re-index. FULL_INDEX_LOCK (held inside
+    // run_full_index_summary_with_conn) still serializes against the periodic run.
+    let app_data_dir = app
+        .path()
+        .app_data_dir()
+        .map_err(|e| format!("failed to resolve app data dir: {e}"))?;
     let summary = tokio::task::spawn_blocking(move || {
-        let conn = conn.lock().map_err(|e| e.to_string())?;
-        let _index_guard = FULL_INDEX_LOCK
-            .lock()
-            .map_err(|e| format!("full index lock poisoned: {e}"))?;
-        run_full_index_unlocked(&conn)
+        let conn = crate::db::init_db(app_data_dir).map_err(|e| e.to_string())?;
+        run_full_index_summary_with_conn(&conn)
     })
     .await
     .map_err(|e| format!("index task join error: {e}"))??;

apps/desktop/src-tauri/tauri.conf.json

@@ -2,7 +2,7 @@
   "$schema": "https://raw.githubusercontent.com/tauri-apps/tauri/dev/crates/tauri-utils/schema.json",
   "identifier": "com.codevetter.desktop",
   "productName": "CodeVetter",
-  "version": "1.1.57",
+  "version": "1.1.58",
   "build": {
     "beforeDevCommand": "npm run dev",
     "beforeBuildCommand": "npm run build",

apps/desktop/src/pages/QuickReview.tsx

@@ -725,6 +725,26 @@ function sameHistoryFile(historyFile: string, findingFile: string) {
   return left === right || left.endsWith(`/${right}`) || right.endsWith(`/${left}`);
 }
 
+/**
+ * Fire a desktop notification if the matching Settings toggle is enabled.
+ * `defaultOn` mirrors the toggle's default so an unset preference behaves like
+ * the Settings UI. Best-effort: never throws into the calling flow.
+ */
+async function notifyIfEnabled(
+  prefKey: string,
+  defaultOn: boolean,
+  title: string,
+  body: string,
+): Promise<void> {
+  try {
+    const raw = await getPreference(prefKey);
+    const enabled = raw == null ? defaultOn : raw === "true";
+    if (enabled) await sendTrayNotification(title, body);
+  } catch {
+    // Notifications are best-effort; ignore permission/plugin failures.
+  }
+}
+
 function parseDiffIntoFiles(diff: string): DiffFile[] {
   if (!diff.trim()) return [];
   const files: DiffFile[] = [];
@@ -1304,20 +1324,13 @@ export default function QuickReview() {
       setSelectedFindings(new Set());
       // Core action: a code review run completed (also fires `activated` once).
       trackCoreAction("review_run");
-      // Fire the "Review Completed" desktop notification (default-on, like the
-      // tray monitor's quota notifications). Best-effort — never block the flow.
-      void getPreference("notify_review_done")
-        .then((raw) => {
-          if (raw === "false") return;
-          const count = res.findings_count ?? res.findings.length;
-          return sendTrayNotification(
-            "Review complete",
-            `${count} finding${count === 1 ? "" : "s"} · score ${Math.round(res.score)}/100 · ${res.diff_range || diffRange}`,
-          );
-        })
-        .catch(() => {
-          // Notifications are best-effort; ignore permission/plugin failures.
-        });
+      const count = res.findings_count ?? res.findings.length;
+      void notifyIfEnabled(
+        "notify_review_done",
+        true,
+        "Review complete",
+        `${count} finding${count === 1 ? "" : "s"} · score ${Math.round(res.score)}/100 · ${res.diff_range || diffRange}`,
+      );
       await blastPromise;
     } catch (e) {
       console.error("[CodeVetter] CLI review failed:", e);
@@ -1328,6 +1341,12 @@ export default function QuickReview() {
         setError(
           "The review couldn't finish. The AI agent may have failed or timed out — check the agent is installed and try again.",
         );
+        void notifyIfEnabled(
+          "notify_agent_error",
+          true,
+          "Review failed",
+          "The AI agent failed or timed out during the review.",
+        );
       }
     } finally {
       setIsReviewing(false);
@@ -2683,6 +2702,12 @@ export default function QuickReview() {
       const completedAt = new Date().toISOString();
       setFixResult(res);
       setFixCompletedAt(completedAt);
+      void notifyIfEnabled(
+        "notify_task_complete",
+        false,
+        "Fix complete",
+        `${res.findings_fixed} finding${res.findings_fixed === 1 ? "" : "s"} fixed across ${res.changed_files.length} file${res.changed_files.length === 1 ? "" : "s"}.`,
+      );
       recordProcedureExecutionEvents(
         procedureEventsForFixResult(activeProcedureSteps, res),
         {
@@ -2709,6 +2734,12 @@ export default function QuickReview() {
       }
     } catch (e) {
       setError(`Fix failed: ${String(e)}`);
+      void notifyIfEnabled(
+        "notify_agent_error",
+        true,
+        "Fix failed",
+        "The AI agent failed while applying the selected fixes.",
+      );
     } finally {
       setIsFixing(null);
       unlisten?.();