Skip to content

Commit 4ce03a9

Browse files
authored
Fix Azure embeddings model detection by passing string to fullURL (#637)
1 parent 09f6920 commit 4ce03a9

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

embeddings.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ func (c *Client) CreateEmbeddings(
228228
conv EmbeddingRequestConverter,
229229
) (res EmbeddingResponse, err error) {
230230
baseReq := conv.Convert()
231-
req, err := c.newRequest(ctx, http.MethodPost, c.fullURL("/embeddings", baseReq.Model), withBody(baseReq))
231+
req, err := c.newRequest(ctx, http.MethodPost, c.fullURL("/embeddings", string(baseReq.Model)), withBody(baseReq))
232232
if err != nil {
233233
return
234234
}

embeddings_test.go

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,32 @@ func TestEmbeddingEndpoint(t *testing.T) {
158158
checks.HasError(t, err, "CreateEmbeddings error")
159159
}
160160

161+
func TestAzureEmbeddingEndpoint(t *testing.T) {
162+
client, server, teardown := setupAzureTestServer()
163+
defer teardown()
164+
165+
sampleEmbeddings := []openai.Embedding{
166+
{Embedding: []float32{1.23, 4.56, 7.89}},
167+
{Embedding: []float32{-0.006968617, -0.0052718227, 0.011901081}},
168+
}
169+
170+
server.RegisterHandler(
171+
"/openai/deployments/text-embedding-ada-002/embeddings",
172+
func(w http.ResponseWriter, r *http.Request) {
173+
resBytes, _ := json.Marshal(openai.EmbeddingResponse{Data: sampleEmbeddings})
174+
fmt.Fprintln(w, string(resBytes))
175+
},
176+
)
177+
// test create embeddings with strings (simple embedding request)
178+
res, err := client.CreateEmbeddings(context.Background(), openai.EmbeddingRequest{
179+
Model: openai.AdaEmbeddingV2,
180+
})
181+
checks.NoError(t, err, "CreateEmbeddings error")
182+
if !reflect.DeepEqual(res.Data, sampleEmbeddings) {
183+
t.Errorf("Expected %#v embeddings, got %#v", sampleEmbeddings, res.Data)
184+
}
185+
}
186+
161187
func TestEmbeddingResponseBase64_ToEmbeddingResponse(t *testing.T) {
162188
type fields struct {
163189
Object string

0 commit comments

Comments
 (0)