Skip to content

Commit 44137e0

Browse files
Abhishek KumarAbhishek Kumar
authored andcommitted
fix: unsupported argument error and test failures
1 parent 7a756df commit 44137e0

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,6 @@ module "netapp" {
276276
depends_on = [module.vnet]
277277

278278
community_netapp_volume_size = var.community_netapp_volume_size
279-
community_netapp_volume_zone = var.node_pools_availability_zone != "" ? tonumber(var.node_pools_availability_zone) : var.community_netapp_volume_zone
280279

281280
# Multi-AZ Cross-Zone Replication Configuration (Changes for PSCLOUD-133 comment)
282281
netapp_availability_zone = var.netapp_availability_zone

modules/azurerm_netapp/variables.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ variable "community_netapp_volume_size" {
7777
variable "netapp_availability_zone" {
7878
description = "Primary availability zone for Azure NetApp Files volume. Set to '1', '2', or '3' for zonal deployment."
7979
type = string
80+
nullable = true
8081
default = "1"
8182

8283
validation {
@@ -94,6 +95,7 @@ variable "netapp_enable_cross_zone_replication" {
9495
variable "netapp_replication_zone" {
9596
description = "Target availability zone for NetApp cross-zone replication. Must be different from netapp_availability_zone."
9697
type = string
98+
nullable = true
9799
default = "2"
98100

99101
validation {

variables.tf

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -566,10 +566,11 @@ variable "netapp_network_features" {
566566
}
567567
}
568568

569-
# ✅ NEW: Multi-AZ NetApp Variables
569+
# Multi-AZ NetApp Variables
570570
variable "netapp_availability_zone" {
571571
description = "Primary availability zone for Azure NetApp Files volume. Set to '1', '2', or '3' for zonal deployment."
572572
type = string
573+
nullable = true
573574
default = "1"
574575

575576
validation {
@@ -587,6 +588,7 @@ variable "netapp_enable_cross_zone_replication" {
587588
variable "netapp_replication_zone" {
588589
description = "Target availability zone for NetApp cross-zone replication. Must be different from netapp_availability_zone."
589590
type = string
591+
nullable = true
590592
default = "2"
591593

592594
validation {
@@ -920,12 +922,3 @@ variable "community_node_os_upgrade_channel" {
920922
error_message = "ERROR: Valid types are \"None\", \"NodeImage\", \"SecurityPatch\" and \"Unmanaged\"!"
921923
}
922924
}
923-
924-
# Community Contribution - NetApp Zone
925-
# Note: NetApp multi-AZ zone variables (netapp_availability_zone, netapp_enable_cross_zone_replication,
926-
# netapp_replication_zone, netapp_replication_frequency) are defined earlier in this file (lines 570-609)
927-
variable "community_netapp_volume_zone" {
928-
description = "Community Contributed field. Specifies the availability zone for the NetApp volume."
929-
type = number
930-
default = null
931-
}

0 commit comments

Comments
 (0)