Skip to content

Commit 421fb41

Browse files
Scott DoverScott Dover
authored andcommitted
chore: stub filter column menu
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
1 parent 6d671dd commit 421fb41

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

client/src/webview/ColumnMenu.tsx

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,14 +178,24 @@ const ColumnMenu = ({
178178
},
179179
],
180180
},
181+
{
182+
name: localize("Filter column"),
183+
onPress: () => {
184+
dismissMenu();
185+
},
186+
},
181187
"separator",
182188
{
183189
name: localize("Properties"),
184190
onPress: loadColumnProperties,
185191
},
186192
];
187193

188-
return <GridMenu menuItems={menuItems} top={top} left={left} theme={theme} />;
194+
return (
195+
<>
196+
<GridMenu menuItems={menuItems} top={top} left={left} theme={theme} />
197+
</>
198+
);
189199
};
190200

191201
export default ColumnMenu;

client/src/webview/GridMenu.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ interface MenuItem {
1212

1313
const GridMenu = ({
1414
dismissMenu,
15+
id,
1516
left: incomingLeft,
1617
menuItems,
1718
parentDimensions,
@@ -20,6 +21,7 @@ const GridMenu = ({
2021
top,
2122
}: {
2223
dismissMenu?: () => void;
24+
id?: number;
2325
left?: number;
2426
menuItems: (MenuItem | string)[];
2527
parentDimensions?: { left: number; width: number };
@@ -155,12 +157,13 @@ const GridMenu = ({
155157
if (left + width > clientWidth) {
156158
setLeft(left - (left + width - clientWidth + 15));
157159
}
158-
}, []); // eslint-disable-line react-hooks/exhaustive-deps
160+
}, [id]); // eslint-disable-line react-hooks/exhaustive-deps
159161

160162
return (
161163
<>
162164
{subMenu && subMenu.items.length > 0 && (
163165
<GridMenu
166+
id={subMenu.index}
164167
dismissMenu={() => {
165168
focusItem(subMenu.index);
166169
setSubMenu(undefined);

0 commit comments

Comments
 (0)